Giter Site home page Giter Site logo

Comments (4)

Salamek avatar Salamek commented on June 14, 2024

PRs welcomed...

from cron-descriptor.

eduardomezencio avatar eduardomezencio commented on June 14, 2024

I'm working on a simple PR for this, but your code-check is not passing right now on the master branch, so I would have to commit without your pre-commit hook. Should I do that? This is the output of the code-check:

.venv ❯ ./code-check.sh 
warning: `ruff <path>` is deprecated. Use `ruff check <path>` instead.
warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'ignore' -> 'lint.ignore'
  - 'select' -> 'lint.select'
  - 'mccabe' -> 'lint.mccabe'
  - 'pylint' -> 'lint.pylint'
  - 'per-file-ignores' -> 'lint.per-file-ignores'
cron_descriptor/ExpressionDescriptor.py:42:27: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
cron_descriptor/ExpressionDescriptor.py:46:25: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
cron_descriptor/ExpressionDescriptor.py:368:14: PLR1714 Consider merging multiple comparisons: `expression in ("LW", "WL")`. Use a `set` if the elements are hashable.
cron_descriptor/ExpressionParser.py:32:18: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
cron_descriptor/ExpressionParser.py:42:20: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
tests/TestExceptions.py:34:14: PT027 Use `pytest.raises` instead of unittest-style `assertRaises`
tests/TestExceptions.py:40:14: PT027 Use `pytest.raises` instead of unittest-style `assertRaises`
tests/TestExceptions.py:45:14: PT027 Use `pytest.raises` instead of unittest-style `assertRaises`
tests/TestExceptions.py:51:14: PT027 Use `pytest.raises` instead of unittest-style `assertRaises`
Found 9 errors.
No fixes available (5 hidden fixes can be enabled with the `--unsafe-fixes` option).

You can assign this issue to me, btw, if you want

from cron-descriptor.

Salamek avatar Salamek commented on June 14, 2024

I guess so, looks like this check needs some fixes too

from cron-descriptor.

eduardomezencio avatar eduardomezencio commented on June 14, 2024

#80

from cron-descriptor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.