Figure out if SDK can work with Savon 2.3.0

[salesforce-marketingcloud]

Figure out if SDK can work with Savon 2.3.0

[barberj]

i confirm this. is it necessary to use savon 2.3.0? Admittedly we don't want to incur technical debt, but curious if there was a use case for savon 2.3.0 or just what came up when you installed

[MichaelAllenClark]

I was really just curious to see what they changes that caused it to no longer work. If it is a simple change to get it working then it would nice to be able to be on the most recent version. I'll have to dig into it in order to find the error that it was causing.

[barberj]

agreed.

On Thu, Sep 19, 2013 at 10:45 AM, Michael Clark [email protected]:

I was really just curious to see what they changes that caused it to no
longer work. If it is a simple change to get it working then it would nice
to be able to be on the most recent version. I'll have to dig into it in
order to find the error that it was causing.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-24744146
.

Justin Barber
(512)JBARBER
.......__o
.......<,
....( )/ ( )

[jmcnevin]

It would be nice to use the latest version of Savon, and by extension, the latest version of Gyoku.

I've run into an issue with trying to save DataExtension rows containing null values. Looking at the ET documentation, it would appear that I need to shape the SOAP messages slightly differently in this case:

https://help.exacttarget.com/en-US/technical_library/web_service_guide/technical_articles/updating_a_data_extension_object_with_a_null_field_value/

However, the version of gyoku that savon 2.0 wants (~>1.0.0) is broken in regards to attaching attributes to arrays, so it's making this a little difficult.

[barberj]

I'm currently running fuelsdk with savon savon-2.3.1. Not sure latest, but i got over the 2.0 hump. I'll create an issue to look into null fields

[yagnik]

@MichaelAllenClark @barberj any work on this ?

[nickhoffman]

Any update on this, @MichaelAllenClark or @barberj?

[johnadamson]

Please see savonrb/savon#518.

I have done some work to fix the issue with versions of Savon > 2.2, which can be found here.

I do not use this gem, but stumbled across the same issue when upgrading a legacy application that consumes the ExactTarget API with an older version of Savon.

I would be happy to open a pull request as the maintainers see fit. I would feel more comfortable doing so if others using the gem directly could verify functionality more thoroughly than I could.

[dholdren]

@johnadamson that LGTM. we have another gem in our app that depends on a modern savon, and we'd really like to see this gem's dependency on savon updated. Could you open a PR against this repo? It might get more traction that way

[johnadamson]

@dholdren as I no longer work with ExactTarget, I'm not the right person to see to any remaining work. Please feel free to take what code I've committed and my best wishes in creating your own PR.

[will-in-wi]

@johnadamson Your branch worked great for us. We are rolling out MarketingCloud right now, and I pushed your code fix into prod.

[will-in-wi]

@johnadamson Would you open a pull request?