Giter Site home page Giter Site logo

Comments (2)

patrickcarlohickman avatar patrickcarlohickman commented on July 20, 2024 1

@jorqensen ,

The currentPage variable is used to track which page the paginator is currently on. When you start and haven't made any requests, the current page is 0 (or, startPage - 1, if you've set the start page). Once you request page 1, then the currentPage will advance to 1.

The applyPagination() method is called before requests to update the request to get the next page. Since you're trying to get the next page, and not the current page, you want to update the request with $this->currentPage + 1.

If you look at the applyPagination() method on the parent PagedPaginator class, you'll see it still uses the deprecated page property (which is equal to $this->currentPage + 1).

Since this property is deprecated, I tend to use $this->currentPage + 1 in my own custom paginators. Also, the $this->currentPage + 1 logic is used multiple times inside the parent Paginator class.

from saloon.

Sammyjo20 avatar Sammyjo20 commented on July 20, 2024

Hey @jorqensen

As Patrick kindly mentioned, the page property does start at 1, but that meant that by the time it ran applyPagination, that value was actually 2, so I deprecated it and introduced currentPage which is the "correct" value. Patrick's suggestion above should be suitable to get pagination working.

from saloon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.