Nice job! And FR: Swappable PSR-7-compliant HTTP client library

[simonhamp]

Nice job! And FR: Swappable PSR-7-compliant HTTP client library

[Sammyjo20]

Hi @simonhamp, thank you for your comments, I really appreciate it!

I'll start off with saying I really like this idea. I don't know a huge amount about PSR-7 (I think is the right PSR) but I do know that Guzzle follows it quite well. I'd like in the future to be able to make swappable clients for Saloon so you can easily build your own Saloon clients/adapters that it uses under the hood.

The main request flow for Saloon is as follows:

1. Request is created and sent method is called
2. Request goes to request manager
3. RequestManager builds up and merges headers, config, interceptors and handlers defined on both the request and the connector
4. RequestManager converts it to a Guzzle response
5. Guzzle sends the request
6. Saloon receives the response
7. Saloon sends you the response

I think Saloon could replace the RequestManager with a SaloonClient, with the default being GuzzleClient. Inside of the client, it would be responsible for building up the request, but it would have access to:

• All the merged headers, config, handlers and interceptors
• The request URL
• The ability to create a Saloon response

That way, you would be able to create any client you like and apply the headers/config/handlers in whichever way the client supports it. If a particular client didn't support middleware/handlers like Guzzle does, maybe you can specify that in the client so Saloon would know to disable that particular feature.

What are your thoughts?

I feel that this would take Saloon to the next level, from being a Guzzle wrapper to being the "Flysystem" of HTTP integrations. As exciting as this is, I'm happy to leave it dependant on Guzzle for the next few months at least, because it's really solid so far, and then as it matures I hope to use this client pattern. I've got a couple of things I want to build in Saloon first like mocking and caching. Once I've built that - I'll say Saloon is ready for version 1.0, after that I'll look into making it pluggable.

[simonhamp]

Totally agree! Only build it if/when it's needed.

Regardless, I'm looking forward to using this package soon

[Sammyjo20]

Sounds great! I’ll happily keep this issue open for now so others can know it’s on my mind.

Hope you have fun with it!

[Sammyjo20]

I will convert this into a discussion to move it away from the issues page 🚀