Comments (11)
I think @zetoke made the point albeit didn't explain it properly.
None of them are dependencies since technically you don't even need to use them, unless you want to use Sagas (redux-saga
/ rxjs
). Generally if you are developing a library, you want to give a user full control over installed dependencies, so that we don't restrict user to have installed two versions just because redux-elm
enforces different version than their application.
from prism.
You can control version of your sagas or rocks in your app.
from prism.
Is "rocks" slang for Rx observables?
This doesn't really answer my question. Why are they peer dependencies? If I decide to use either, I will simply add them as dependencies to my own project, just like redux-elm
should add them as dependencies to it.
from prism.
Is "rocks" slang for Rx observables?
@dalgard sorry, my fault. It does not slang. Auto-correction on my phone has corrected from rxjs
to rocks
from prism.
@tomkis1 Thanks. So it comes down to avoiding an extra version. It's unfortunate that it shows up as a warning in the console, since it gives the impression that I'm doing something wrong, even when I don't need the two libs.
@zetoke It kinda makes sense as a slang word, though :)
from prism.
@dalgard well actually, you should install those two dependencies to avoid the warning, because either way sooner or later you will get to the point when sagas come handy ;-)
from prism.
No doubt – I would argue that any real-world app need a saga. Communicating correctly is important, though.
Avoiding the bundling of two different versions of the same package in one app is probably something that should be done manually when optimizing the bundle size, anyway?
from prism.
I'm thinking that the peer dependency feature isn't used all the time for a good reason.
Also, what about RxJS? I probably won't be using observables in my app, however great they are.
from prism.
So what do you suggest @dalgard should we put redux-saga
and redux-saga-rxjs
in dependencies instead?
from prism.
Only if they are actually used somewhere in redux-elm
.
I can't figure out what relationship redux-elm
have to these two libraries – the contents of this folder puzzles me.
from prism.
Maybe, but I'd still prefer to give user a chance to choose the right version of redux-saga
and rxjs
because they will most likely have these libraries already and the last thing we want is same library in different versions.
from prism.
Related Issues (20)
- Don't Call PropTypes HOT 3
- Sibling components interaction best practice HOT 6
- Performance HOT 2
- Request to join cdnjs HOT 1
- Build a umd package for Browser usage
- Reduce bundle size by using rxjs modularity HOT 1
- Mount order and saga registering HOT 8
- Get currentUser state in component Updater HOT 3
- Sagas not getting unmounted HOT 2
- Version 4.x.x HOT 7
- redux-saga update HOT 2
- Documentation links 404 HOT 5
- Where is documentation for v3? HOT 2
- Props 'selector' and 'wrapper' get passed down to enhanced component HOT 3
- prism-redux/escapeRegexp.js is missing a character in the regex
- Questions about using side-effect libraries with prism
- How to wrap/unwrap dynamic components? HOT 2
- Provide a wrapper compatible with the library-provided unwrapper
- EnhanceComponent doesn't work with thunk middleware
- Dynamic list of stateful components HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prism.