[BUG] error thrown for incomplete profile but does not indicate which attribute is missing a value

[salt-extensions]

[BUG] error thrown for incomplete profile but does not indicate which attribute is missing a value

[nicholasmhughes]

Please post the exact error received. Thank you!

[DaveLafleur]

[ERROR ] There was a query error: No value for given attribute
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/salt/cloud/cli.py", line 319, in run
ret = mapper.run_map(dmap)
File "/usr/lib/python3/dist-packages/salt/cloud/init.py", line 2196, in run_map
output[name] = self.create(profile, local_master=local_master)
File "/usr/lib/python3/dist-packages/salt/cloud/init.py", line 1226, in create
output = self.cloudsfunc
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 149, in call
return self.loader.run(run_func, *args, **kwargs)
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1201, in run
return self._last_context.run(self._run_as, func_or_method, *args, **kwargs)
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1216, in run_as
return func_or_method(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/saltext/azurerm/clouds/azurerm.py", line 1271, in create
vm_request = request_instance(vm=vm)
File "/usr/local/lib/python3.8/dist-packages/saltext/azurerm/clouds/azurerm.py", line 895, in request_instance
iface_data, public_ips, private_ips = create_network_interface(call="action", kwargs=vm)
File "/usr/local/lib/python3.8/dist-packages/saltext/azurerm/clouds/azurerm.py", line 711, in create_network_interface
subnet_obj = netconn.subnets.get(
File "/usr/local/lib/python3.8/dist-packages/azure/core/tracing/decorator.py", line 78, in wrapper_use_tracer
return func(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/azure/mgmt/network/v2021_08_01/operations/_operations.py", line 57344, in get
request = build_subnets_get_request(
File "/usr/local/lib/python3.8/dist-packages/azure/mgmt/network/v2021_08_01/operations/_operations.py", line 14408, in build_subnets_get_request
"resourceGroupName": _SERIALIZER.url("resource_group_name", resource_group_name, 'str'),
File "/usr/local/lib/python3.8/dist-packages/msrest/serialization.py", line 652, in url
output = self.serialize_data(data, data_type, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/msrest/serialization.py", line 760, in serialize_data
raise ValueError("No value for given attribute")
ValueError: No value for given attribute

[nicholasmhughes]

Yeah, it doesn't look like there's any parameter verification in that section. We'll leave this open so we can build in that error reporting.

In the meantime, the following parameters in your profile need to be changed:

virtual_network_name > network
subnet_name > subnet
resource_group_name > resource_group (or network_resource_group if in a different rg than the rest of your resources)

They don't track the SDK names for the parameters... so that might be another thing we want to standardize.