Comments (7)
@pherrmann Sorry it took so long, had a couple of issues I needed to resolve with the automated release process.
Can you try it out now with the latest versions of @salte-auth/salte-auth
, @salte-auth/wso2
, and @salte-auth/redirect
?
from salte-auth.
@cecilia-sanare yes, the latest update is importing the *.min.js
now and I'm no longer getting those import errors.
from salte-auth.
Hey Phil!
First off, thanks for taking the time to try it out!
Angular 2+
I'll try to look into the Angular 9 issue tonight.
I'm guessing you're using angular-cli
for your compilation process?
Documentation
Regarding the documentation, I don't seem to be having issues accessing it via that URL.
I don't imagine this is the issue, but did you try accessing it off VPN?
from salte-auth.
Based on my initial review, I think the removal of queryParams
will require me to create a custom provider to pass a custom query param to my wso2 provider. The migration guide could potentially be enhanced by highlighting what public methods and properties were removed from SalteAuth and the config options. There you could note what the migration path is for those specific items.
Angular
Yes, you should be able to recreate by using the angular cli to create their initial "hello world" app ng new my-app
. In the generated AppComponent, import the Salte-Auth packages, initialize SalteAuth with a provider, handler like the migration guide. Doesn't seem to matter whether you do that in the Component's constructor or in a random const
outside the class.
Documentation
Regarding the docs, I do get to the main page above. I'm referring to the links down the right of the page. Those go to a "file not found" page. Previously, you could browse the api docs to see what was publicly available on SalteAuth, the config options, etc.
from salte-auth.
So I looked into this a little bit and it looks like nested imports aren't resolving the way I'd expect.
e.g.
When you import @salte-auth/salte-auth
it resolves to module
.
Line 5 in a8caf5b
However, when you import @salte-auth/redirect
and it imports @salte-auth/salte-auth
for some reason webpack resolves to main
.
Line 4 in a8caf5b
Still looking to see if there's anything I can add to the package.json or in the angular.json file to hint at webpack regarding how it should be resolving this.
from salte-auth.
queryParams
Instead of creating a custom provider, you can also use the Generic Providers and use @salte-auth/wso2
as an example.
I'll also look into readding the ability to provide extra parameters to any of the providers. (#411)
Lines 10 to 26 in a8caf5b
Documentation (#412)
Good catch, didn't even notice that!
Not sure why considering the files exist within the repository.
https://github.com/salte-auth/salte-auth.github.io/blob/master/modules/_base_core_events_.html
from salte-auth.
I think I've found a solution that will work without you making any changes to your configuration.
Basically, if I add a browser
property in the package.json
file then angular-cli
will resolve the compiled file via that property instead of using module
or `main.
This means that it will resolve the .js
file instead of the .mjs
file.
I'll have to update every package, unfortunately, I'll let you know when I'm done!
from salte-auth.
Related Issues (20)
- An in-range update of @polymer/polymer is breaking the build 🚨 HOT 1
- Find a tool to validate documentation coverage for TypeScript
- Atom auto-complete / intellisense
- (3.x) Add support for custom parameters HOT 2
- (3.x) Generated API Doc links don't work HOT 6
- (3.x) Improve generated documentation
- invalid_state with redirect login while popup login works with same config HOT 8
- @salte-auth/salte-auth: TypeScript users shouldn't have to validate the Provider type. HOT 4
- Convert Tests to TypeScript
- UserInfo should support non-standard properties HOT 1
- redirectUrl set as RedirectUrl INTERFACE object not working HOT 3
- salte.SalteAuth is not a constructor on Glitch demo HOT 2
- Figure out why SauceLabs refuses to connect
- @salte-auth/salte-auth: Custom `state` parameter
- @salte-auth/popup: Promise should be rejected when popup is closed
- @salte-auth/iframe: Add detection for Identity Providers that block iFrames
- Sveltekit / Server-side Rendering Support HOT 4
- Cannot run yarn successfully HOT 1
- Custom storage guide HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from salte-auth.