Giter Site home page Giter Site logo

Comments (8)

saltnpixels avatar saltnpixels commented on June 18, 2024 1

I made an adjustment so certain plugins will work better with ignition so you may want to download again. :) (plugins like bbpress or big plugins like that...)

Some plugins use page.php to show all their stuff even if it's an archive or a post type. This didn't sit well with ignition which routes your pages based on is_page(). So That has been fixed.

from ignition.

saltnpixels avatar saltnpixels commented on June 18, 2024

Unfortunately I cannot find a way to refresh the logo position in the customizer when you add/remove menu items.
I cannot find a callback or function for the wp customizer when it comes to adding a menu item. There isn't really any documentation on the javascript side of the wp menu that I can find. :(

The good news is it won't affect the site when it is live, it's only in the customizer. Until I figure out a fix, just make sure to add your menu items first then change the logo location.

from ignition.

ThatKDB avatar ThatKDB commented on June 18, 2024

Understandable. I was also having the display issue on the live site after publishing the change. The logo seems to have a display:none applied. I'll give your suggestion a try to see if it is a viable workaround for me.

BTW, thanks for a great starter theme. I'm giving it a spin for a new project, which will be my first custom theme ;)

from ignition.

saltnpixels avatar saltnpixels commented on June 18, 2024

from ignition.

ThatKDB avatar ThatKDB commented on June 18, 2024

Awesome! I just generated a new download and have copied it over to my project. Thanks for the goodies!

from ignition.

ThatKDB avatar ThatKDB commented on June 18, 2024

I tried your suggested workaround -- doesn't quite work at the moment. It ends up putting the site logo in the sub menu of the menu item to the right of where the logo should be. I'll try to see if I can play with it so more next week.

from ignition.

saltnpixels avatar saltnpixels commented on June 18, 2024

It seems to be working for me. I guess I would need some more information

from ignition.

ThatKDB avatar ThatKDB commented on June 18, 2024

I tested on the dev environment from my webhost and I don't get any of these issues there. Must be related to the Local by Flywheel local environment. My hosted dev install doesn't experience the disappearing logo in customizer either. I wasn't able to see anything in the console. I tried in multiple browsers and using private windows with similar results. Must be some weird issue from LbF.

from ignition.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.