Comments (9)
How did I become a code owner ;-) We need to encourage issue raisers to contribute PRs too. Okay, the value
apache: {{ apache|json }}
was added a few years ago, I can raise a PR.
@noelmcloughlin Well, I usually check the blame to see who last changed the section which has caused the regression and then ping accordingly. It's nothing personal! However, you're probably going to get more pings when there's wholescale changes made to formulas!
from apache-formula.
PR merged. closing. Quick turnaround, thanks guys.
from apache-formula.
Thanks for the report, @ixs. I add that the entries under the context
block need to be indented by another 2 spaces as well:
apache-formula/apache/config/vhosts/standard.sls
Lines 22 to 26 in e2e1be1
Meaning:
- context:
apache: {{ apache|json }}
id: {{ id|json }}
...
@noelmcloughlin Could you have a look at this, please?
from apache-formula.
from apache-formula.
No need. I have something locally which I'm testing already as PR.
from apache-formula.
from apache-formula.
#298 is the PR... Works fine locally. We're still passing way too much information per templating call but at least we're not using exponentially more memory...
from apache-formula.
Thanks for the issue. Lets keep it open for a while.
I raised #299 as follow-up. There may be more but this PR was obvious.
from apache-formula.
👍🏻
There are more cases where full dicts are passed,but the bad ones are where it's done per iteration like in vhosts.
from apache-formula.
Related Issues (20)
- execute purge after uninstall
- Default log formats doesn't use IP from mod remoteip in debian
- [BUG] apache.vhost.cleanup fails if apache is not yet installed HOT 2
- [FEATURE] support mod_md
- In Debian apache.config plays two opposite actions HOT 1
- A recursive requisite was found in apache.config.modules.mod_security
- [BUG] use of tpldir variable does not allow the formula to be wrapped HOT 12
- [BUG] apache.config.vhosts.standard: mapping error when "enabled: false" HOT 3
- yaml syntax error in mod_pagespeed.sls HOT 1
- [BUG] syntax error near "module;" in apache/config/register_site.sls line 66 HOT 1
- [BUG] apache.config.modules.mod_wsgi fails, pkg: apache not found HOT 2
- [BUG] On CentOS 7, enabled modules are reported as changed on every highstate HOT 1
- [BUG] apache.config.vhosts.cleanup now remove the service HOT 3
- [BUG] in vhosts/standard.sls the map.pop affects the apache variable as well because it is a reference, not a copy HOT 3
- [BUG] ssl.conf should never be removed - should always be managed
- [BUG] vhost proxy.tmpl doesn' add DocumentRoot
- [BUG] ID apache-service-running in SLS apache.service.running is not a dictionary
- [FEATURE] Add SSLCACertificate
- [FEATURE] handle multiple CustomLog directives
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apache-formula.