Comments (6)
Testing ssh config before restarting the service looks like a good idea to me. Do you think you can provide a pull request with the code?
from openssh-formula.
@OrangeDog @daks This has already been implemented in .config
via salt.states.file.managed
's check_cmd
.
https://github.com/saltstack-formulas/openssh-formula/blob/master/openssh/config.sls#L17
https://docs.saltstack.com/en/latest/ref/states/all/salt.states.file.html#salt.states.file.managed
from openssh-formula.
@alxwr cool, just needs implementing for config_ini then.
from openssh-formula.
@OrangeDog check_cmd
uses a temporary file which contains the new config.
Based on your last comment I guess you agree with my view on salt.states.file.managed
's check_cmd
. Is that correct?
@OrangeDog @aboe76
In my view .config_ini
is a special case which only changes the way in which sshd_config
gets its values. It was implemented in #124.
I propose to extend .config
with .config_ini
by overwriting ID sshd_config
. This way we get all the additional features (i.e. key mgmt) within .config
plus INI format.
from openssh-formula.
@alxwr nice Idea, can you create a PR then we can test this.
from openssh-formula.
@aboe76 I assigned the issue to myself, but I can't promise any completion date. :-)
So if anyone wants to create a PR before, feel free to do so. (Just give me an update in this thread when you start. I'll do the same.)
from openssh-formula.
Related Issues (20)
- SSH options not created using file-based public keys.
- Some minor version issues HOT 2
- Indenting does not render properly HOT 2
- openssh.config_ini / HostKey clobbering HOT 1
- Needs workaround for RedHat-family 6.x with SELinux enabled ("check_cmd execution failed ... Permission denied") (fix included) HOT 2
- Remove blank lines in rendered ssh_config and sshd_config HOT 6
- Jinja error: variable 'dict object' has no attribute 'ssh_config'
- Wish: Add support for Win32-OpenSSH HOT 1
- Indicate deprecated config HOT 2
- Sort example pillar options HOT 1
- config_ini duplicating lines due to tab instead of space (e.g. Subsystem) HOT 14
- Implement `semantic-release` for this formula HOT 17
- Convert tests from Serverspec to Inspec (working on both Docker and Vagrant) HOT 1
- Change file extension of `_pillar/known_hosts_salt_ssh.sls` to `.py`
- [BUG] ssh_config multiple IdentityFile not supported HOT 4
- Deprecated option UsePrivilegeSeparation HOT 2
- [BUG] When running with salt-ssh, getting error that 'opts' is not defined. HOT 2
- [BUG] Aliases in known_hosts not picked up HOT 2
- [BUG] Log cluttered with message: "'delimiter' and 'merge' options of 'config.get' are skipped when the salt command type is 'unknown'" HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openssh-formula.