Giter Site home page Giter Site logo

PyPI version is wrong about pepper HOT 9 CLOSED

saltstack avatar saltstack commented on August 9, 2024
PyPI version is wrong

from pepper.

Comments (9)

whiteinge avatar whiteinge commented on August 9, 2024

I can reproduce this. Do you know where pip fetches that version information from? It should be available in the metadata but it looks like I missed something.

I don't delete old releases off PyPI. Try editing the URL: Example:

https://pypi.python.org/pypi?name=salt-pepper&version=0.2.0&:action=display

from pepper.

kottenator avatar kottenator commented on August 9, 2024

Yes, now I see that all versions are presented, excuse me

from pepper.

kottenator avatar kottenator commented on August 9, 2024

However, installed version is still 0.0.0 :)
Sorry, I can't quickly find the reason of the bug

from pepper.

whiteinge avatar whiteinge commented on August 9, 2024

from pepper.

EugeniuZ avatar EugeniuZ commented on August 9, 2024

I believe this is the source of the bug: https://github.com/saltstack/pepper/blob/master/setup.py#L47
git_dir is empty after this call and as a result version and sha are None.

To be more precise: it works when you install it from the local git folder but it won't work if you install it from pypi.

from pepper.

whiteinge avatar whiteinge commented on August 9, 2024

Oh, good catch! You're right. If there's no Git directory we should look for the JSON file instead. facepalm

If you care to send a pull req with the fix, I will push a new version to PyPI.

from pepper.

EugeniuZ avatar EugeniuZ commented on August 9, 2024

#61

from pepper.

whiteinge avatar whiteinge commented on August 9, 2024

Thanks for the fix! Release 0.4.0 is now cut and uploaded to PyPI.

from pepper.

EugeniuZ avatar EugeniuZ commented on August 9, 2024

You're welcome. Thanks for uploading it so fast.

from pepper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.