Giter Site home page Giter Site logo

Comments (9)

samchon avatar samchon commented on July 20, 2024 1

Then, I will solve this problem by myself. Thanks for reporting.

from nestia.

samchon avatar samchon commented on July 20, 2024 1

@SkyaTura Then which directory name would be better when generating DTO automatically?

Also, how to do if duplicated directory exists?

from nestia.

SkyaTura avatar SkyaTura commented on July 20, 2024

@samchon depending on your thoughts about how this should be solved, I would be happy to help with this one too.

My only limitation is that I don't know deeply about reflection yet. I actually just learnt what it is, with your code 🙈

from nestia.

SkyaTura avatar SkyaTura commented on July 20, 2024

@samchon is it possible to bring whole type declarations to the output source, instead of just import?

In projects that use nest as private modular packages, it would also be useful to create a whole new independent package for the SDK.

from nestia.

samchon avatar samchon commented on July 20, 2024

@SkyaTura

Writing whole DTO without import statement is enough possible llike below:

However, need to distinguish which to import or re-write the whole DTO.

Have you any plan to dstinguish them? What about distinguish them by object-literal-expression?

//----
// IMPORT
//----
// WHEN DTO TYPE IS CLEARLY DEFINED
export interface IFormalDto {
    id: string;
    name: string;
}

//----
// WHOLE RE-WRITE
//----
// OBJECT-LITERAL-EXPRESSION
class SomeController {
    someMethod(): Promise<{ id: string; name: string; }>
}

// ALIAS TYPE FOR OBJECT-LITERAL-EXPRESSION
type SomeAlias = {
    id: string;
    name: string;
};

from nestia.

SkyaTura avatar SkyaTura commented on July 20, 2024

@samchon

Would be nice to have a configuration flag that allows you to switch between "always rewrite", which could be used to create a fully independant package, or "import when possible", which would work like you said.

If I didn't misunderstood, the implementation os the second option is harder because the type isn't always clear, right?


Thinking further about it, would be useful as well if, in the future, we could, optionally, pass each type to a transformer, or some kind of hooks, defined in nestia.config, that could be used to create helper functions like form validation and object generators.

May I create an issue to elaborate how could this be useful and how could be the usage, or do you think it's out of the project scope?

from nestia.

SkyaTura avatar SkyaTura commented on July 20, 2024

@samchon how about using Custom AST Transformers?

@ksaldana1 had a pretty similar scenario as we do, and as demonstrated here, and in an awesome blog post, which describes the development of the idea in steps.

I think this could also be useful in #141, if approved.

from nestia.

samchon avatar samchon commented on July 20, 2024

@SkyaTura I'd been busy by another open source project. I'll try this on this sunday.

However, when nestia re-writes all DTO, have you any idea to where those new DTOs to be placed in?

Also, do you have any idea if duplicated DTO name exists?

from nestia.

SkyaTura avatar SkyaTura commented on July 20, 2024

Hmm... I think, ideally a SDK should have unique type definitions, and by extension, I would always try to avoid duplicates in the API as well.

But this is definitely not a well adopted as standard and should be supported by a generator.

Maybe using namespaces to replicate the original path tree, but I really need to wonder a lit bit about this question.

If we had infinite resources I would suggest multiple strategies, but unfortunitely we should also think what would be more feasable.

from nestia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.