off commands not part of output gcode

[sameer]

off commands not part of output gcode

[sameer]

Hey sloev,

I recently refactored the code I wrote for gcode parsing and I set the tool off action to be the tool on action. 🤦‍♂️

Fix is pushed in a72ab62. I'll be looking into adding tests that cover these and other edge cases so it doesn't happen again

[sloev]

@sameer hey thanks for replying!!!
btw i fixed my situation by using a 3 line postprocessor that alternates between off/on, but having it in the tool is preferable!
bt the way here is something i was able to make thanks to your software!!! (thanks a bunch!)

[sloev]

btw i can help with creating a basic test suite if you want it @sameer ?
it will take me no time

[sameer]

Sure, that would be helpful!

…

On Thu, Mar 4, 2021, at 07:32, sloev wrote: btw i can help with creating a basic test suite if you want it @sameer <https://github.com/sameer> ? it will take me no time — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACUVICHTQHQF2OF5YOFURCDTB54VNANCNFSM4YRNNCYQ>.

[sameer]

I missed seeing that picture you shared when I replied by email 😯
what does the SVG look like?