Unwrapping errors should always throw an `Error` object

[samhh]

Unwrapping errors should always throw an `Error` object

[OliverJAsh]

e => e instanceof Error ? e : new Error(e)

Maybe we could use Error.cause: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause

[samhh]

e => e instanceof Error ? e : new Error(e)

Maybe we could use Error.cause: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause

That looks nice:

> Error('bar', { cause: Error('foo') })
Error: bar
    at REPL5:1:1
    at Script.runInThisContext (node:vm:129:12)
    ... 7 lines matching cause stack trace ...
    at [_line] [as _line] (node:internal/readline/interface:893:18) {
  [cause]: Error: foo
      at REPL5:1:23
      at Script.runInThisContext (node:vm:129:12)
      at REPLServer.defaultEval (node:repl:572:29)
      at bound (node:domain:433:15)
      at REPLServer.runBound [as eval] (node:domain:444:12)
      at REPLServer.onLine (node:repl:902:10)
      at REPLServer.emit (node:events:525:35)
      at REPLServer.emit (node:domain:489:12)
      at [_onLine] [as _onLine] (node:internal/readline/interface:422:12)
      at [_line] [as _line] (node:internal/readline/interface:893:18)
}

The only thing that gives me pause is that if a consumer is using their own error classes extending Error they'll lose the ability to check instanceof directly on the thrown error, which may be surprising:

> class Error2 extends Error {}
> e2 = new Error2()
> ee = new Error('', { cause: e2 })
> e2 instanceof Error2
true
> ee instanceof Error2
false

[samhh]

4046691