Giter Site home page Giter Site logo

Note Range Limitations about moppy2 HOT 13 CLOSED

sammy1am avatar sammy1am commented on May 30, 2024
Note Range Limitations

from moppy2.

Comments (13)

Lothean avatar Lothean commented on May 30, 2024 1

I already expanded the notePeriods array in Arduino/Moppy/src/MoppyInstruments/MoppyInstrument.h which already increased the note range of the software.
You should check your mapper configuration for note limits or your instrument.
If the range is still not wide enough for you, expand the notePeriods, noteDoubleTicks and noteTicks arrays!

from moppy2.

dmadison avatar dmadison commented on May 30, 2024 1

Don't feel bad, I had the same question. See this issue on the "Classic" repo.

from moppy2.

Sammy1Am avatar Sammy1Am commented on May 30, 2024 1

Looks good to me! (That should work fine for you devices, hopefully) If you want to do future users a favor and just go ahead and finish off the array, I'd be happy to accept a pull request :)

from moppy2.

Lothean avatar Lothean commented on May 30, 2024 1

Ah. I think you need to modify the file Arduino/Moppy/src/MoppyInstruments/FloppyDrives.cpp
Set the value of const byte MAX_FLOPPY_NOTE to 128 and it should work fine!

from moppy2.

ApplesOfEpicness avatar ApplesOfEpicness commented on May 30, 2024

Forgive me for being so uneducated, but how exactly do i convert notes into microseconds?

from moppy2.

ApplesOfEpicness avatar ApplesOfEpicness commented on May 30, 2024

@Lothean

I already expanded the notePeriods array in Arduino/Moppy/src/MoppyInstruments/MoppyInstrument.h which already increased the note range of the software.
You should check your mapper configuration for note limits or your instrument.
If the range is still not wide enough for you, expand the notePeriods, noteDoubleTicks and noteTicks arrays!

I'm not sure what i'm doing wrong. I've expanded the arrays from C0 all the way to C8. However, my highest note is still cutting out right before C7?

from moppy2.

Lothean avatar Lothean commented on May 30, 2024

Have you expanded all 3 arrays as they were supposed to ?

from moppy2.

ApplesOfEpicness avatar ApplesOfEpicness commented on May 30, 2024

@Lothean

This is what I did. I think it's right but i might be wrong.
MoppyInstrument.txt

from moppy2.

ApplesOfEpicness avatar ApplesOfEpicness commented on May 30, 2024

@Sammyiam

But the notes are still cutting out before C7?

from moppy2.

Lothean avatar Lothean commented on May 30, 2024

@ApplesOfEpicness
Which instrument are you using ?

from moppy2.

ApplesOfEpicness avatar ApplesOfEpicness commented on May 30, 2024

@Lothean

Software wise or hardeware wise? The software is set for normal floppies, but the instrument I’m physically using is a hard drive voice coil which has a nearly unlimited tone range.

from moppy2.

ApplesOfEpicness avatar ApplesOfEpicness commented on May 30, 2024

Huh, I was looking in the .h file instead of the .cpp. Yep, works pretty well. Some higher notes are out of tune so I’ll work on fixing that later.

Thanks for the help guys!

from moppy2.

Lothean avatar Lothean commented on May 30, 2024

Concerning the notes that are a bit off, you should try setting the timer resolution to 20!

from moppy2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.