Giter Site home page Giter Site logo

Comments (4)

juse-less avatar juse-less commented on May 3, 2024 1

Sorry for the short comment. I'm on my phone, but was hoping the pointer is enough to help. 🙂

The Saloon documentation says this:
https://docs.saloon.dev/digging-deeper/oauth2-authentication#getting-setup

We recommend that you create a new connector in your integration just for authentication with the third-party provider. This can help keep the authentication and API code separate

from saloon.

Sammyjo20 avatar Sammyjo20 commented on May 3, 2024 1

Hey @jacksontong

Apologies for the delay on this one!

Have you tried passing the full URL into your authorization code config?

protected function defaultOauthConfig(): OAuthConfig
{
    return OAuthConfig::make()
	->setAuthorizeEndpoint('https://api.hubapi.com/oauth/v1/access-tokens')
        ->setTokenEndpoint('/oauth/tokens')
}

I believe Saloon should recongnise that the endpoint is a full URL and will use that instead of combining the base URL + endpoint.

See the URL helper code which is used by Saloon when building URLs:

https://github.com/Sammyjo20/Saloon/blob/v2/src/Helpers/URLHelper.php#L28

from saloon.

jacksontong avatar jacksontong commented on May 3, 2024

Thanks for quick reply, but in this case it's just the authorization url which has different base url, whilst the access and refresh token base url is still api

https://api.hubapi.com/oauth/v1/access-tokens/

We recommend that you create a new connector in your integration just for authentication with the third-party provider. This can help keep the authentication and API code separate

With this approach I'll have to create oauth connector just to generate the authorization url, and the api connector still have to implement oauth to exchange the token.

https://developers.hubspot.com/docs/api/oauth/tokens

from saloon.

jacksontong avatar jacksontong commented on May 3, 2024

yep, it works. Thanks for your support.

from saloon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.