Access to `->body()` while building custom cache key at cacheKey()

[sammyjo20]

Access to `->body()` while building custom cache key at cacheKey()

[Sammyjo20]

This has now been fixed in v2.1 of the cache plugin 🔥 Thank you for raising this! https://github.com/Sammyjo20/saloon-cache-plugin/releases/tag/v2.1.0

[Sammyjo20]

Hey @boryn

Ah I have found a way we can get around this - I will just implement a fix for you.

[boryn]

Hi @Sammyjo20 !

Looking at the original CacheKeyHelper:

public static function create(PendingRequest $pendingRequest): string
{
    $className = $pendingRequest->getRequest()::class;
    $requestUrl = $pendingRequest->getUrl();
    $query = $pendingRequest->query()->all();
    $headers = $pendingRequest->headers()->all();

    return json_encode(compact('className', 'requestUrl', 'query', 'headers'), JSON_THROW_ON_ERROR);
}

I started to think if it may happen that $pendingRequest->query() or $pendingRequest->headers() is null? It's possible with $pendingRequest->body() that this is null.

In that case not to raise an error of running ->all() on null we'd rather need:

$query = optional($pendingRequest->query())->all();
$headers = optional($pendingRequest->headers())->all();