Comments (6)
Looks like the same idea of embedding multiple animation in the same resource instead of giving individual resource.
Yes we can provide the api for the same .
I guess they only need the layer list of the composition layer to support this feature .
Anyway just check with them do they need all the layer's (layer can have child layer ) or only the 1st level children list .
from rlottie.
Let's consider api point of view,
My idea is we could provide an additional public class to manipulate or obtain internal attributes by "id"
ie,
class AttribAccessor
{
AttribAccessor(Animation* animation);
void frame(string& id, size_t* start, size_t end);
};
The (potential) user may call like this,
attribAccessor->frame("focus_in", &start, &end);
attribAccessor->frame("focus_out", &start, &end);
This class could expand functions to access more attirbute such as color, geom, xxx by id.
from rlottie.
Well if Accessor takes the animation object , you still have to expose the api in animation class to be used by Acessor. if its not a friend class(in case of friend class case both will inter depend on each other).
So just adding the api in Animation class is much simpler approch.
from rlottie.
Did you check with the VD , if they need only 1st level children or the whole layer tree ? Is MinWoo Lee is working on the VD side ? I can ask him for the exact requirement.
from rlottie.
As Animator class, it should be responsible for only animation behavior feature because it may need to support more property access, not only this layer frame. If so, animator may have over methods for providing various property access. And the second reason is accessing properties is not the ordinary functions for normal usage.
And About PropertyAccessor(as attribAccessor), it's just one example suggestion we can start to consider, since animator and PropertyAccessor both are wrapper interfaces, they would have actual bodies as internal private classes, they both could be friends to communicate.
The implementation is on you but you can consider my feedback, In the meantime, I think the property customizer as a coming feature, this request could be considered together.
from rlottie.
@smohantty for layer question, you can contact to MinWoo Lee
from rlottie.
Related Issues (20)
- On Windows rlottie hangs (forever) on application shutdown when compiled with MinGW HOT 1
- Can't build rlottie with static linking using MinGW
- librlottie-image-loader.so lacks SONAME HOT 2
- JSON license could be removed HOT 1
- Result of fuzzing tests HOT 1
- Use after free in surface cache code
- Add API for clearing the cache HOT 2
- totalFrame() is one frame less
- ClamAV reports viruses found from rlottie's source HOT 1
- Suggest fuzzer for rlottie::Animation::loadFromFile()
- How to get all keypaths?
- How to adapt to high-definition screen
- Cannot build for wasm, trying fix security issue HOT 1
- What is missing in the text_support branch to finish the feature?
- Performance regression with Blendmode introduction HOT 5
- How to port it to 2d gpu
- Simple moving circle not playing properly HOT 1
- Is the underlying graphics rendering using opengl? HOT 1
- Compile error while porting on bare metal
- Error porting rlottie to arm platform
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rlottie.