Ensure that if an opened terminal is not on the workspace root folder it navigates to it

[samuelpordeus]

Ensure that if an opened terminal is not on the workspace root folder it navigates to it

[mracos]

Maybe this could be solved if we always use fullPaths for the files

[msramos]

We can use this approach for individual files (runTestFile and runTestAtCursor), but the runTestSuite command must run from project's root.

[GustavoSantosFe]

Maybe this could be solved if we always use fullPaths for the files

mix test doesn't like it when you use the full path, I tried it 😢

[samuelpordeus]

Ok, just to move forward with this issue: we are going with option 3. PRs are welcome 😅

[samuelpordeus]

let's go with that solution ☝️

[mracos]

So it's 👎to using full paths then, since they do not work. 😞

Because of that, I thought of some approaches to find out the app root folder:

• Going up recursively relative from the current test file until we find a mix.exsand then assume it is the project root.
• Get the "opened" folder in vscode and assume it is the project root (maybe it would not work with umbrella apps?)
• Going up recursively until we find a .git directory and assume it is the project root (maybe it does not work with git submodules?)

I rather like the first option, it seems to be the best one for me but maybe you folks have any other ideas? I'm all ears. 😄

[msramos]

Why no just cd the root folder?

[mracos]

But how do we know which one is the root folder?
That's what the options above are, maybe I should have been more explicit 😄

[samuelpordeus]

I think that a good approach is to assume that the root folder of the Elixir App is the root folder of the vs-code workspace.

With that in mind, we have three options when the user tries to run the test suite outside root:

1. Warn him that he is not on the root
2. Create a new terminal on the root and run mix test
3. cd to the root and run mix test

WDYT about these approaches? That could even be configurable 🤔

[GustavoSantosFe]

I like options 2 and 3
3 is easier but 2 is less likely to cause problems to the user

[msramos]

This is going to be included in the next release!