Comments (4)
Hi Suhas,
the implementation section depends on the first "METHOD …" line, therefore you'd get:
Kind regards,
Jörg-Michael
from abap-cleaner.
Hi Suhas,
with "Derive from first statement", ABAP cleaner indeed separately determines the casing from
- the first statement in a class definition (i.e. the CLASS ... DEFINITION line itself)
- the first statement in a class implementation (i.e. the CLASS ... IMPLEMENTATION line itself)
The idea behind this is that in class definitions, SE80 always seems to use lower case keywords and upper case identifiers (regardless of the settings in menu "Utilities / Settings" -> ABAP Editor -> Pretty Printer), while for class implementations, SE80 does observe these settings, so SE80 could produce different formatting for the implementations (e.g. upper case keywords and lower case identifiers).
Therefore, if "derive from first statement" would now only derive the settings from the CLASS … DEFINITION line and someone in the team still uses SE80, you would always end up to have everything in lower case keywords and upper case identifiers – and that might not be intended, even by the SE80 users.
But you're right: SE80 does seem to put CLASS <NAME> IMPLEMENTATION
to upper case! That makes this line rather useless to derive the settings from, of course. I think the best way to solve this would be to derive the settings for the implementation part from the first "METHOD method_name" line.
If that's still not satisfying, we could of course consider to add another option to the "Auto-determine upper/lower case" selection, so everyone could decide for themselves:
- "derive from first statement in code document" (as ABAP Formatter does)
- "derive from first statement of a class definition / method implementation"
Kind regards,
Jörg-Michael
from abap-cleaner.
"derive from first statement of a class definition / method implementation"
This is promising 🥇
from abap-cleaner.
Hi Suhas,
thanks again for this hint! The renamed option and adjusted behavior was now released with version 1.5.3, hope it helps!
Kind regards,
Jörg-Michael
from abap-cleaner.
Related Issues (20)
- Update from 1.16.2 to newer version deinstalled ABAP Cleaner and now i am not able to install ABAP Cleaner HOT 1
- Installation with Eclipse & ADT 2024-06 (4.32)
- Adjustion alignment of parameters and conditional expressions HOT 2
- Alignment of select-options and parameters
- Feature Request: ABAP cleaner on an entire package
- perhaps interesting for ABAP Cleaner too: Sort combined DATA statements (ABAP Quick Fixes 1.1.5)?
- Single line TYPES: statements do not always have the colon removed HOT 1
- Rule "Remove space before commas and period" duplicates template comment in function module HOT 3
- CALL FUNCTION ... DESTINATION
- Error when constant is used to specify variable size HOT 2
- Enhancement: skip unsupported statements instead of cancelling whole cleanup
- "Use FINAL" rule doesn't work when method is called in COND HOT 2
- Feature Request: Introduce ABAP-Cleaner Pragmas (e.g. skip certain code sections from applying rules) HOT 3
- Alignment of method declarations with ABSTRACT
- Feature request: Replace obsolete REFRESH with CLEAR
- Link to install file down? HOT 2
- DDL: Standardize spaces around colon, coma... with namespaces HOT 3
- Feature request: Support of Clean ABAP only one statement in a single line HOT 2
- Align parameters and components: Minimum line length is 80
- Alignment of comment when using enumerated PERFORM HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abap-cleaner.