Giter Site home page Giter Site logo

Comments (7)

aborjinik avatar aborjinik commented on June 8, 2024

TextArea does not have valueStateText property.
I am not sure I get the input issue right

from openui5.

hschaefer123 avatar hschaefer123 commented on June 8, 2024

;-) You are right. It has a valueState but not a valueStateText (very consequent).

From my Point-of-view that feature should be part of InputBase, because every input can lead to parse/validation errors and i need a unique/generic way to show field errors.

What do you mean?

So currently for TextArea this is a feature request, but the layout issue depends on Input fields placed inside dialogs. In most situations, the valueState will be shown under the input, but im some situation it will not get hided correctly. Maybe additionally a z-index issue besides the hide issue.

from openui5.

aborjinik avatar aborjinik commented on June 8, 2024

Initially InputBase was not designed only for writable fields. So the idea was using it for all type of html inputs like checkbox, radio, file... That's why InputBase does not have maxLength or it does not fire liveChange event. We could create a new control e.g TextField between InputBase and writable inputs and inherit Input,TextArea from TextField but now when we look at the framework it is only used for writable fields except DateTimeInput.

So from my point of view this is a valid feature request for InputBase any more.

I still could not reproduce the input issue but will look into it closer.

Thanks for your feedback.

from openui5.

hschaefer123 avatar hschaefer123 commented on June 8, 2024

on chrome if i slowy click twice into the inputfield, it seems that the valueState will be brought to back without hiding (like screenshot). first click show error value state, second click pushes it back. Maybe this helps to reproduce (tested in jsbin)

from openui5.

aborjinik avatar aborjinik commented on June 8, 2024

OK I see the issue now. I will report to the control owner.
Thanks for your feedback.

from openui5.

balexan avatar balexan commented on June 8, 2024

Fixed in 1.24.

from openui5.

akudev avatar akudev commented on June 8, 2024

Also fixed in 1.22 now and fix will be in the next 1.20 patch (1.20.11). Closing. Thanks!

from openui5.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.