Giter Site home page Giter Site logo

Comments (2)

HrFlorianHoffmann avatar HrFlorianHoffmann commented on June 11, 2024

We all agree that IF object->is_active( ) is easier on the eye than the repetitive IF object->is_active = abap_true.

On the other hand, consider the overhead of adding getters. The few characters you save in the conditions you spend several times over in the definition and implementation of the repetitive getters.

Doing this exclusively for Boolean attributes is questionable, as it mixes up different styles in the same class. Your co-developers will probably ask you to add getters for all 42 attributes, not only the 3 Boolean ones, for symmetry and clarity. For non-Boolean attributes, you will not be able to avoid the comparison value, such that getters will not provide any benefit.

The section Consider using immutable instead of getter deliberately says "consider" to leave this choice to you.

The best choice of course would be to allow IF object->is_active right away, if is_active has a clearly Boolean data type.

from styleguides.

openPhiL avatar openPhiL commented on June 11, 2024

That is a good explanation, thanks! Will keep that in mind.
Allowing IF object->is_active would be great. I guess it is coming eventually.

from styleguides.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.