Giter Site home page Giter Site logo

Comments (2)

saprykin avatar saprykin commented on June 29, 2024

Thanks for the PR! I have a few questions to clarify:

  • Maybe we should not have a test for 4GB. My concern is what would happen on Windows XP with less than 4 GB? Some embedded machines may also have less than 4GB of physical memory available. There is a clear problem with Windows API usage (what PR is fixing), but I would prefer to avoid having extreme test cases which potentially cannot be run on low-performance machines.
  • In LOWDWORD macro, why do you need to do shifts at all? I guess you can just cut high word like this: #define LODWORD(l) ((DWORD)((DWORDLONG)(l)))

from plibsys.

leekunpeng avatar leekunpeng commented on June 29, 2024

Sorry for the delay.

I agree with you, 4GB is really not needed for testing on a windows XP machine. I added this just to test, i suggest you can remove it.
But now i am using plibsys to develop cross-platform applications. Our program have a need to mem allocate 4GB of shared memory on windows. So i summit a PR. I have change LOWDWORD macro and delete 4GB mem test.

Can you please help to solve this problem?
Thanks a lot!

from plibsys.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.