Preserve Aspect Ratio

[sarriaroman]

Preserve Aspect Ratio

[jlno]

+1

[sarinsukumar]

Ok, l will probably look to fix it, will update you.

Best Regards

Sarin sukumar A

On Thu, Nov 3, 2016 at 6:24 PM, Román A. Sarria [email protected]
wrote:

@sarinsukumar https://github.com/sarinsukumar @mk79
https://github.com/mk79 sadly the fix was made to avoid problems with
images bigger than 100kb. Maybe a PR can be created to make it conditional
but introduces the problem of the images again. I'm trying with a different
library but still in testing.
Maybe works for y

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#41 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAzEhh82lEgh0Iyn-Z-JxXU2UCQrECcQks5q6dl1gaJpZM4KkPyS
.

[ekrapfl]

I have submitted a pull request to correct the issue.

[dawidfiruzek]

Created pull request with fix to preserve the aspect ratio of the images #45

[sarinsukumar]

This commit has broken behavior.
9f200b1

[sarriaroman]

Can you please tell me if Android or iOS? Thanks!

[mk79]

@sarriaroman it's on Android (Samsung Galaxy S7)

[sarriaroman]

@sarinsukumar @mk79 sadly the fix was made to avoid problems with images bigger than 100kb. Maybe a PR can be created to make it conditional but introduces the problem of the images again. I'm trying with a different library but still in testing.
Maybe works for you just change the plugin from the android project but take care of the size of the image because your app will blow up.

[sarinsukumar]

Is there a way I can change plugin source from the project ? will it reflect ? I tried but not reflecting the changes. I think may be we can resize the image while showing it to restrict within certain size.