Bug in summBg() when show.rates=T and inoc.name not specified

[jonasoh]

Bug in summBg() when show.rates=T and inoc.name not specified

[jonasoh]

Ah, I realize now that the sorting is for the diff() to work of course. What about sorting the whole summ1 dataframe just before the for loop on L478?

[sashahafner]

Ah, I realize now that the sorting is for the diff() to work of course.

Yup. Added comment to code now.

What about sorting the whole summ1 dataframe just before the for loop on L478?

Good suggestion. Earlier approach seems completely wrong, doesn't maintain order between summ1 and dd subset. Probably the problem wasn't noticed earlier because this code typically sorts around line 427:

  if(!is.null(inoc.name)) {

    # Merge inoculum normalized volumes with sample data
    summ1 <- merge(summ1, inoc.vol, by = time.name)

Implemented your suggestion with a76aaff

[sashahafner]

@jonasoh please close this issue if the solution seems OK. Also check new version of DESCRIPTION with added author: https://github.com/sashahafner/biogas/blob/dev/DESCRIPTION

[sashahafner]

Also let me know if you want to be added to this repo as a collaborator @jonasoh. Then you could make changes without a pull request. Up to you. It is OK if you prefer to just use pull requests or make suggestions in comments instead.

[jonasoh]

Looks good!

Thank you for the recognition in DESCRIPTION. It suits me well to submit a PR or issue if/when I stumble upon something.