Giter Site home page Giter Site logo

Comments (6)

elyezer avatar elyezer commented on September 26, 2024

The design decision behind product_install and all *_install tasks was that every install task should return a map for installer options, then the katello_installer task grab that information and run the install command. One way to refactor is to adopt the same approach for Satellite 5 related tasks or think a different approach and make product_install handle it if doing a Satellite 5 installation.

from automation-tools.

Ichimonji10 avatar Ichimonji10 commented on September 26, 2024

Thanks for the explanation, @elyezer.

from automation-tools.

lpramuk avatar lpramuk commented on September 26, 2024

I'd go for separate satellite5_product_install to avoid frequent if conditions for sat5 vs. sat6

from automation-tools.

elyezer avatar elyezer commented on September 26, 2024

👍

Then I recommend moving all the satellite5 related tasks to automation_tools/satellite5.py module, later we can refactor Satellite 6 and SAM tasks to similar modules.

from automation-tools.

lpramuk avatar lpramuk commented on September 26, 2024

Submitted PR #180
Oops, looks like I missed elyezer last comment, yet I'd like to incorporate it in.

from automation-tools.

lpramuk avatar lpramuk commented on September 26, 2024

Resolved as PR #180 was merged.

from automation-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.