Giter Site home page Giter Site logo

Comments (5)

savq avatar savq commented on July 17, 2024 2

You're right. install foo actually prints after foo is installed, and you're also right in thinking that's confusing.

I've thought about this a little, and I think that having a buffer or a floating window with the installation info. makes sense. Updates rarely fail, but when they do it's super important to know which one failed.

Note: I'm on finals, so this might take a while :P


Implementation notes:

  • The user should be able to choose whether the buffer opens automatically, or only on failure. Maybe add a setup function?
  • Read :h api-buffer
  • See whether the buffer and process counter have to be locked
  • Have a table of message strings, and interpolate the repo name when necessary (this can also reduce the number of strings already hardcoded)

from paq-nvim.

savq avatar savq commented on July 17, 2024 2

Update:

Showing the number of packages currently downloaded/updated, and phrasing the prompt messages in the past tense is already in dev.

No-ops count as a success; uninstalls or hooks aren't counted, since there's no way to know a priori how many will run.

Aditionally, I've settled on not adding a floating window. Instead, Paq will write failures to a log file. The log has several advantages: It's persistent and optional, a user can look at it at whatever time, or not at all; it's also more in line with how other Lua functionality works (both the lsp and treesitter have their own log files).

from paq-nvim.

ojroques avatar ojroques commented on July 17, 2024

That would be great indeed.

from paq-nvim.

Furkanzmc avatar Furkanzmc commented on July 17, 2024

Will there be a way to automatically open the log file when the update finishes? I find it very useful to see the commit log after an update, would it be a lot of work to include that in the logs? Or would it even make sense to include it in the logs?

from paq-nvim.

savq avatar savq commented on July 17, 2024

Will there be a way to automatically open the log file when the update finishes?

Having a configuration option to do that shoundn't be much trouble.

...see the commit log after an update...

My first instinct would be not to add that, since Paq updates things out of order, the log file could become quite a mess. Having separate functionalities to display the log of a single repo might make more sense, but for now it feels a bit out of scope. We can revisit the idea later.

from paq-nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.