I implemented a hot restart on fasthttp, but it cannot be implemented on atreugo because I can't access net.listen of atreugo.server

[savsgio]

I implemented a hot restart on fasthttp, but it cannot be implemented on atreugo because I can't access net.listen of atreugo.server

[savsgio]

Can I use server.ServerPtr() or server.RouterPtr() ?
Because in a project I might want to set router.RedirectTrailingSlash to false.
Thanks. :-)

Finally, I added this https://godoc.org/github.com/savsgio/atreugo#Atreugo.RedirectTrailingSlash.
Now you could change internal options of router.

I will release a new version in a few days.

PD: I don't add ServerPtr and RouterPtr, to protect it of bad uses that could break atreugo

[imxxiv]

I know, Thanks for add RedirectTrailingSlash.

[imxxiv]

Can I use server.ServerPtr() or server.RouterPtr() ?
Because in a project I might want to set router.RedirectTrailingSlash to false.
Thanks. :-)

[savsgio]

What do you mean with I can't access net.listen of atreugo.server??

[imxxiv]

func createListener(addr string) (net.Listener, error) {
	//ln, err := net.Listen("tcp", addr)
	ln, err := reuseport.Listen("tcp6", addr)
	if err != nil {
		return nil, err
	}

	return ln, nil
}
func createOrImportListener(addr string) (net.Listener, error) {
	// Try and import a listener for addr. If it's found, use it.
	ln, err := importListener(addr)
	if err == nil {
		fmt.Printf("Imported listener file descriptor for %v.\n", addr)
		return ln, nil
	}

	// No listener was imported, that means this process has to create one.
	ln, err = createListener(addr)
	if err != nil {
		return nil, err
	}

	fmt.Printf("Created listener file descriptor for %v.\n", addr)
	return ln, nil
}

In order to achieve hot restart, I have to get ln, but getListener() in atreugo is private function

[savsgio]

You don't need access to getListener(), because you could create your own listener and use it with myatreugoserver.Serve(ln).
getListener it's just for ListenAndServe()

If you need a listener with reuseport, you could set to true the Reuseport option in configuration, and run server with ListenAndServe(), avoiding to create a FileListener shared with child processes, because you could run any servers that using the same port (with different listeners) at the same time.

The both options are valid.

[savsgio]

So, if you want to create your own listener, change this function with something like that:

func startServer(ln net.Listener) *atreugo.Atreugo {
	config := &atreugo.Config{
		Name: "fast",
	}
	server := atreugo.New(config)

	server.Path("GET", "/hello", handler)
	//r.GET("/test", test)
	//r.GET("/web", web)

	go server.Serve(ln)

	return server
}

[imxxiv]

Reuseport can listen same port at the same time !

Then in principle, it is very simple to implement hot restart.

1. set reuseport true and ServeGracefully true, compile and run the program
2. after add handle, compile and run the program angin, and kill the old pid of the old program

The old server will Gracefully exit, and new server will go on to work.
Is this correct in my understanding?

[savsgio]

Yep 😄 hehe