Comments (6)
I found this fix for jsdom dorny/jsdom-little#1
It's working.
from angularjs-server.
@l0ne thanks for digging in to this. Sorry I didn't get back to you sooner.
It looks like that jsdom fix has only gone into the jsdom 5.x.x line, but the 3.x.x line is the last one that supports NodeJS. Did you get it working by altering jsdom locally, or is there a fork of jsdom on npm that you used?
(jsdom is actually a dependency we inherit from node-angularcontext, so the bug is arguably over there, but I also maintain that library so no big deal.)
It's been a concern of mine that we can't adopt new versions of jsdom without breaking Node compatibility, but so far that concern had been theoretical. Our instance of angularjs-server is still running on an 0.10.x release of Node so we've not run into this problem yet, but when I get some spare time I'll try to see whether there's a reasonable solution here.
from angularjs-server.
@l0ne did this ever get fixed for node >= 0.12, the weather example is not work for me and I am getting the same error. I have a project with node 4.2 and Angular 1.4 and would like to see if this module can be used.
from angularjs-server.
I am getting the same error. I have a project with node 4.4.1 and Angular 1.2.8 and would like to see if this module can be used.
from angularjs-server.
This is still broken. I've tried updating angularcontext to fix it, however while angularcontext is using a later jsdom it has other issues. Looking at fixes for those too..
https://github.com/rjmackay/angularjs-server/tree/update-angular-context
https://github.com/rjmackay/node-angularcontext/tree/fix-run-context
from angularjs-server.
Hi all,
Sorry for the silence here.
We tried to get this fixed up a few weeks ago but ran into issues since angularcontext (the library this is built on) is depending on some features of jsdom that are no longer available once it's upgraded. It's likely that this module needs to be redesigned a bunch before it can work on Node 4. We'd like to undertake this eventually, but haven't been able to prioritize it yet.
from angularjs-server.
Related Issues (20)
- typo in README.md HOT 2
- Rework in the browser? HOT 2
- New pull request HOT 1
- mistake in readme
- Is 'eponymous' a fork? HOT 1
- Hard to use angular from npm? HOT 12
- Make angularjs-server work with ui-router HOT 1
- Slash of the end HOT 1
- Example Broken HOT 5
- Crashes on Windows HOT 1
- Express depency is bad HOT 4
- Any plans to update to recent jsdom and nodejs? HOT 3
- overriding $httpBackend breaks $browser.notifyWhenNoOutstandingRequests HOT 6
- query strings not parsed correctly
- Can't work in child route HOT 5
- Fast render AngularJS on server HOT 1
- TypeError: Cannot read property 'ownerDocument' of null HOT 1
- Error: location not available yet HOT 3
- Access to module from nodejs HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angularjs-server.