No tests are run with junit-platform 1.2.0 and jupiter 5.2.0

[sbrannen]

No tests are run with junit-platform 1.2.0 and jupiter 5.2.0

[sbrannen]

Please try tag 1.2.0 and report back whether that works for you.

Thanks in advance!

[whiskeysierra]

An indicator why I believe the problem is with the SpringExtension can be seen here: https://travis-ci.org/zalando/logbook/builds/379081572

Running the same tests against spring boot 2 (+ spring 5) and using the official SpringExtension from Spring 5 (by disabling our junit5 profile), it works. Even with the newer JUnit/Jupiter versions.

[whiskeysierra]

Might be related to this, maybe?

<!-- for some reason, this is needed to make spring-test-junit5 work -->
<dependency>
    <groupId>org.junit.platform</groupId>
    <artifactId>junit-platform-commons</artifactId>
    <version>${junit-platform.version}</version>
    <scope>test</scope>
</dependency>

https://github.com/zalando/logbook/blob/master/logbook-spring-boot-starter/pom.xml#L118

[whiskeysierra]

Works! Thanks for the fast response! 🎉

[sbrannen]

You're welcome!

And thanks for letting me know the new tag works.