Generated import not compatible with new Scala 3 syntax

[kubukoz]

Generated import not compatible with new Scala 3 syntax

[martingd]

@kubukoz

About final vals - #158

Thanks for the pointer. And it seems to do the trick also for annotation parameters.

As for the import, I also don't see why it'd be necessary unless someone disables the default imports.

I had a discussion about this issue on Discord and it seems the import is there for exactly for that reason: if somene uses Yno-imports or -Yno-predef. See commit e924a28

I am not sure why someone would do that and if we need to keep the import then the plugin will need to generate Scala 2/3 specific code.

[armanbilge]

I ran into this too. Here's my workaround:

// put this in project directory and use with:
// buildInfoRenderFactory := sbtbuildinfo.Scala3CaseObjectRenderer.apply

package sbtbuildinfo // couldn't access ScalaCaseObjectRenderer outside this pkg (?)

final case class Scala3CaseObjectRenderer(
    options: Seq[BuildInfoOption],
    pkg: String,
    obj: String)
    extends ScalaRenderer {
  private lazy val delegate = ScalaCaseObjectRenderer(options, pkg, obj)

  def extension: String = delegate.extension
  def fileType: BuildInfoType = delegate.fileType
  def renderKeys(infoKeysNameAndValues: Seq[BuildInfoResult]): Seq[String] =
    delegate.renderKeys(infoKeysNameAndValues).map {
      case "import scala.Predef._" => "import scala.Predef.*"
      case x => x
    }
}

[martingd]

@kubukoz and @eed3si9n, is that import of scala.Predef._ even necessary at all?

Removing it, the code still compiles with Scala 3, 2.12, 2.11, and 2.10.
(I haven't tried to compile with earlier Scala versions as it requires a JDK earlier then 1.8.)

So I would suggest getting rid of the import altogether and also (which is a different issue) change code generation so all vals are final and without a type annotation as the vals then can be used as constants in annotation parameters.

For example, instead of generating

val version: String = "1.5.0+2-44650e3c-SNAPSHOT"

we should generate this

final val version = "1.5.0+2-44650e3c-SNAPSHOT"

[kubukoz]

About final vals - #158

As for the import, I also don't see why it'd be necessary unless someone disables the default imports.