Comments (7)
Aren't GitHub releases based on the user published tags?
Not necessarily. It is possible to create a new release from Releases GitHub page which will in turn create a new tag. That tag is going to be a lightweight one.
from sbt-dynver.
You're right, I forgot about that safe-guard - I agree it makes the risk very low.
Go ahead, and welcome, my first contributor :)
from sbt-dynver.
It's a design decision to only consider annotated tags (aka exclude lightweight tags).
I should document that.
But what do you mean by "created by GitHub when cutting a new release"? Aren't GitHub releases based on the user published tags?
from sbt-dynver.
Is there a problem when considering lightweight tags in the describe?
from sbt-dynver.
Using lightweight tags to define the version means you can never use tags for anything but the version. For instance you can't create a local "before-refactor" tag, for your convenience, and you have to use SHAs all the time. I personally believe this is a waste of a great feature in git, so I prefer only annotated tags are used for versions.
But I'm happy for sbt-dynver to have an opt-in feature that includes lightweight tags.
from sbt-dynver.
... you can never use tags for anything but the version ...
Are you concerned of a version being inadvertently derived from a tag which was not meant to be a version tag?
sbt-dynver
uses --match
to only consider tags that start with a v
and a number. That should be enough to have this risk very low.
Or is there something else that I am missing?
from sbt-dynver.
Fixed by #15
from sbt-dynver.
Related Issues (20)
- What is the best way to prepend a dependency version number in front of the version ? HOT 4
- Allow getting full Git commit hash HOT 1
- Better support for meaningful SemVer-compliant versions HOT 3
- Default version pattern leads to conflicting versions HOT 7
- Possible to use with sbt-native-packager?
- Move to sbt org? HOT 3
- Config to automatically increment to next major, minor or patch version HOT 7
- Can't override `isVersionStable`
- Breaks with SHA longer than 8
- Should this plugin only be enabled on CI environment? HOT 1
- Selects wrong version if multiple lightweight tags point to the same commit HOT 1
- Artefacts not available HOT 10
- Admin stuff HOT 2
- Release 5.0.0 HOT 2
- dynverAssertTagVersion throws NullPointerException
- Support peeking at remote history / tags? HOT 1
- Task for printing out dynver for arbitrary commit
- Add setting/ability to use basic snapshot versioning with the hash.
- -rcX Tag suffix ignored HOT 1
- make behaviour configurable so that `previousStableVersion` can ignore M0/RC0 versions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sbt-dynver.