Comments (6)
Note that eventually we'll have a Scala 2.12.20 with the scala-xml 2.3.0 upgrade; I just submitted scala/scala#10782.
IMO, it should work for zinc to have a newer scala-xml dependency than scala-compiler does, so it seems to me that something unusual went wrong here. Do we understand what happened, why the dependency was duplicated rather than the older version being evicted?
from sbt.
To avoid classloading scala-library and scala-compiler, sbt launcher creates directories for:
- boot Scala version (the Scala version used by metabuild)
- boot JARs (the rest of sbt main JARs)
and uses a layered classloader at runtime of sbt.
So pluginData#dependencyClasspath
I'm guessing is more of an approximation of that situation that we use for the compilation of plugins.
I guess what we should consider is dropping scala-xml from Zinc as a direct dependency so we'd always use whatever Scala 2.x uses at least during Zinc 1.x?
from sbt.
I guess what we should consider is dropping scala-xml from Zinc as a direct dependency
Yeah, I was thinking of suggesting that. I can't think of a downside, but that could be my lack of imagination and/or knowledge. Zinc is cross-published for other versions besides 2.12, I think? Could something go wrong on 2.13 or 3?
from sbt.
Zinc is cross published to Scala 2.13 for 1.x branch.
I guess the complication is that there are modules in sbt like library management that use scala-xml but doesn't depend on the compiler or Zinc, so the diamond dependency issue would remain even if we work around this one.
The other direction of the workaround might be to deduplicate when calculating the plugin classpath so only one of the duplicates are returned to the user.
from sbt.
So pluginData#dependencyClasspath I'm guessing is more of an approximation of that situation that we use for the compilation of plugins.
@eed3si9n Maybe have any suggestions for a better value which we could use to represent a meta-build in IntelliJ?
from sbt.
Somehow related: Define SBT API / Better modularisation for SBT internals
from sbt.
Related Issues (20)
- About plugin download request address
- Incremental test (testQuick) + nested tests
- [2.x] Publish sbt plugins using platform prefix HOT 5
- [2.x] `ActionCache` is broken on Windows HOT 5
- [2.x] Add `ActionCache` scripted tests
- [2.x] Cache deactivation on task HOT 3
- [2.x] Reduce allocation and heap usage
- [2.x] Deprecate and remove settings
- [2.x] Group settings by plugins (stretch goal)
- [2.x] Cache failed compilation, and other failed tasks
- [2.x] Distinguish between client and server options
- Getting Error in sbt shell Caused by: java.lang.ClassNotFoundException: sbt.State$Next HOT 2
- Java compiler missing annotation warnings halt compilation on windows HOT 1
- [1.x] scripted for sbt 2.x
- [2.x] testQuick doesn't invalidate on resource changes
- [2.x] testQuick doesn't invalidate on testOptions change
- [2.x] Metals cannot import build using BSP HOT 1
- [2.x] Change test to be testQuick
- [2.x] Headless mode
- [2.x] common settings do not work without root HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sbt.