Giter Site home page Giter Site logo

Comments (10)

empicano avatar empicano commented on August 15, 2024 3

We do this in our free time and for fun, sometimes things take a a little while, and that's okay. If you want to speed things up, you can offer to help out, maybe Jonathan will take you up for it πŸ™‚

from aiomqtt.

JonathanPlasse avatar JonathanPlasse commented on August 15, 2024 2

Hey @empicano, @frederikaalund,

Managing typings for both paho-mqtt 1.6.1 and the newer 2.0 version adds many complexities. Given that 1.6.1 is significantly outdated now, I'm leaning towards fully embracing version 2.0 and discontinuing support for the older one.

This will allow us to leverage the latest features and improvements in 2.0. What are your thoughts on making this transition?

from aiomqtt.

JonathanPlasse avatar JonathanPlasse commented on August 15, 2024 1

I will do the PR tonight.

from aiomqtt.

skewty avatar skewty commented on August 15, 2024

Is there a compelling reason to not couple "^2.0" and work with it as it is by default?

I did a quick look at the paho v2 asyncio examples and it doesn't look like much has changed / changes look minimal.

from aiomqtt.

JonathanPlasse avatar JonathanPlasse commented on August 15, 2024

This is not as trivial as I thought, the typing and mypy are getting in the way.

from aiomqtt.

empicano avatar empicano commented on August 15, 2024

Sounds sensible to me πŸ‘ The extra maintenance burden doesn't seem worth it πŸ™‚

from aiomqtt.

frederikaalund avatar frederikaalund commented on August 15, 2024

I agree, it sounds very sensible to drop support for the v1.x line of paho.mqtt.

from aiomqtt.

skewty avatar skewty commented on August 15, 2024

Did this work move into another fork / repo or did development stall? I am not seeing any changes in 5 days.

1862ead

from aiomqtt.

skewty avatar skewty commented on August 15, 2024

Will this go out to pypi as v2.1?

Currently testing it out (no issues so far):

[tool.poetry.dependencies]
aiomqtt = { git = "https://github.com/sbtinstruments/aiomqtt.git", rev = "8321217" }  # until > v2.0.1 released

from aiomqtt.

skewty avatar skewty commented on August 15, 2024

Is some issue holding up a new pypi release? If so, perhaps this issue should be re-opened with a link to that issue.

from aiomqtt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.