Comments (5)
Reopening issue because the interaction with comments is a legitimate bug for us to fix.
from solidity-coverage.
You might have got lucky here without providing further context. Do you happen to have something like:
returns (uint256) {//This is a comment on the function
from solidity-coverage.
You are right! I added a space and it passes.
I now hit a solidity bug about calling twice the same modifier (with two different values).
Should be fixed in 0.4.15 I think, and doesnt exist in 0.4.11.
solidity-coverage currently depends on 0.4.13.
,/home/jerome/src/eth/contracts/coverageEnv/contracts/HeroCoin.sol:356:5: DeclarationError: Modifier already used for this function.
updateAccount(_to) //update receivers rake before transfer as well, to avoid over-attributing rake
^----------------^
,/home/jerome/src/eth/contracts/coverageEnv/contracts/HeroCoin.sol:372:5: DeclarationError: Modifier already used for this function.
updateAccount(_to) //update receivers rake before transfer as well, to avoid over-attributing rake
from solidity-coverage.
That's only a dev dependency, needed for running our tests. During the tests of your project, your contracts should still be compiled by truffle, I think, so I don't think that is a solidity-coverage issue.
from solidity-coverage.
I agree, ultimately I think it is a package management issue.
I have a globally installed truffle using globally installed solc 0.4.11 which compiles my contracts.
Locally I have another truffle and solidity-coverage. When running solidity-coverage I believe it uses solc 0.4.13.
I'll try again when truffle uses latest solc.
Thanks!
from solidity-coverage.
Related Issues (20)
- Consider using caret range for dependencies HOT 3
- named mapping keys printing large logs HOT 3
- Coverage overwrites provider logic in extendEnvironment hook HOT 8
- uncovered else statements HOT 1
- ParserError solidity-coverage: v0.8.5 Solidity 0.8.19 HOT 3
- modifierWhitelist causes inaccurate coverage HOT 3
- Specify minimum coverage HOT 1
- v0.9.0 Road Map
- ...
- Update tests
- Running solidity-coverage against a generic RPC node HOT 12
- Small docs Improvements
- Unskip stack-too-deep unit test HOT 1
- Try/Catch should be treated as branch
- 0% coverage when using hardhat-foundry & foundry.toml is present HOT 15
- Add tests for file level function declarations
- feature: track config state in Hardhat cache
- Tracking Issue: using viaIR in versions >= 0.8.7 HOT 2
- Branch coverage decreases after upgrading to 0.8.7 HOT 10
- Verify skipFiles works as expected when using hardhat-foundry HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from solidity-coverage.