Giter Site home page Giter Site logo

Comments (5)

area avatar area commented on July 17, 2024 1

Reopening issue because the interaction with comments is a legitimate bug for us to fix.

from solidity-coverage.

area avatar area commented on July 17, 2024

You might have got lucky here without providing further context. Do you happen to have something like:

returns (uint256) {//This is a comment on the function

from solidity-coverage.

jeromerousselot avatar jeromerousselot commented on July 17, 2024

You are right! I added a space and it passes.

I now hit a solidity bug about calling twice the same modifier (with two different values).
Should be fixed in 0.4.15 I think, and doesnt exist in 0.4.11.
solidity-coverage currently depends on 0.4.13.

ethereum/solidity#2621

,/home/jerome/src/eth/contracts/coverageEnv/contracts/HeroCoin.sol:356:5: DeclarationError: Modifier already used for this function.
    updateAccount(_to) //update receivers rake before transfer as well, to avoid over-attributing rake
    ^----------------^
,/home/jerome/src/eth/contracts/coverageEnv/contracts/HeroCoin.sol:372:5: DeclarationError: Modifier already used for this function.
    updateAccount(_to) //update receivers rake before transfer as well, to avoid over-attributing rake

from solidity-coverage.

area avatar area commented on July 17, 2024

That's only a dev dependency, needed for running our tests. During the tests of your project, your contracts should still be compiled by truffle, I think, so I don't think that is a solidity-coverage issue.

from solidity-coverage.

jeromerousselot avatar jeromerousselot commented on July 17, 2024

I agree, ultimately I think it is a package management issue.
I have a globally installed truffle using globally installed solc 0.4.11 which compiles my contracts.
Locally I have another truffle and solidity-coverage. When running solidity-coverage I believe it uses solc 0.4.13.
I'll try again when truffle uses latest solc.
Thanks!

from solidity-coverage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.