Comments (8)
Hmm ... I'm not super keen on hard-coding a dependency on Scala IDE bundles. Isn't there a more generic way of recognizing build errors?
from equinox-weaving-launcher.
I agree. AFAIK, there's no way around that: the launcher has to decide what marker ID it recognises, and by default it's the JDT ones. One way is to have an optional dependency, and at runtime check to see if the bundle is loaded.. if it is, perform the additional checks, otherwise do nothing.
An alternative is to hardcode the ID (it's a string, unlikely to change). I can implement either one, just let me know what you prefer :)
from equinox-weaving-launcher.
How about an extension point? You could register marker ids of interest with the launcher (which would default to the JDT ones as it does now).
from equinox-weaving-launcher.
We run into the same issue: I don't want to have a hard dependency on the weaving launcher either :) Most Scala projects don't need it, it's only for Scala IDE devs.
from equinox-weaving-launcher.
Hmm ... How about adding an attribute to the error markers?
from equinox-weaving-launcher.
Yes, this would work. But then we have the problem of where to define the attribute name. If it's on the weaving-launcher side, we'd need a dependency in Scala IDE. And the other way around.
Here's an alternative: markers have super-types, and Scala problem markers extend jdt.core
problem markers. The default implementation checks for exact match, but the weaving launcher could check that the marker is a subtype of the jdt problem marker. WDYT?
from equinox-weaving-launcher.
So long as the string is well-known and guaranteed to be fixed I don't think that's too much of a problem. OTOH checking for a JDT problem marker subtype works too and arguably ought to be done anyway. So, yup, something along those lines would be good :-)
from equinox-weaving-launcher.
I'd go for subtyping any day! :)
from equinox-weaving-launcher.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from equinox-weaving-launcher.