Giter Site home page Giter Site logo

Comments (40)

sarahgerweck avatar sarahgerweck commented on June 3, 2024 3

Like @devisaneer, I'd love to see this as well: the fix to #45 / #91 is something that would be quite useful for my project.

from scala-xml.

biswanaths avatar biswanaths commented on June 3, 2024 3

Really sorry for lot any and all for this inordinate delay.

I am restarted to work on this. Please do expect a release in couple of days.

from scala-xml.

SethTisue avatar SethTisue commented on June 3, 2024 2

1.0.6 is bundled with Scala 2.12.1, which came out today

from scala-xml.

biswanaths avatar biswanaths commented on June 3, 2024 1

Merged #98 and #100 .

Thanks again @ashawley . Only if each of my thank was a dollar, Aaron would be a millionaire.

from scala-xml.

ashawley avatar ashawley commented on June 3, 2024

@biswanaths Happy to review, but I can't see draft releases it seems.

from scala-xml.

adriaanm avatar adriaanm commented on June 3, 2024

Here's the draft. Is it time to add @ashawley to the committers team, @biswanaths? :-)

The following changes have been incorporated in this release

  • Administrative:
    • Remove stale branch, wip/jsuereth-use-module-plugin
    • Update crossScalaVersions to 2.11.8 from 2.11.7
    • Update crossScalaVersions to 2.12.0-M3 from 2.12.0-M1 and 2.12.0-M2
    • Change mimaPreviousVersion in build.sbt to more recent scala-xml than 1.0.1
    • Ask Scala compiler to update versions.properties to next release of scala-xml
  • Following issues has been fixed and enhancements are been made:
    • Merged #67 Travis container changes
    • Merged #69, #70, #80 README updates
    • Merged #78 Add more unit tests for #43
    • Merged #81 Use NodeSeq.fromSeq
    • Merged #84 Remove final keyword from scala.xml.MetaData per FIXME
    • Merged #59 Exponential complexity in BasicTransformer fixing #58
    • Merged #87 Enable SBT builds for Java 1.7 and 1.9
    • Merged #88 Unit test for verifying complexity in #59
    • Merged #91 Empty xmlns attribute fixes #45
    • Merged #92 Fix #35 OOM on malformed input

This release was made possible by contributions from @SethTisue,@adriaanm, @ashawley, @lrytz, @som-snytt.
We would like to thank them for their help.

from scala-xml.

adriaanm avatar adriaanm commented on June 3, 2024

Those are some nice release notes! Looks like you're all set for v1.0.6! Once you publish the release, the commit will be tagged and travis will stage a release on sonatype. Let me know when it's done so I can push the button to promote the staging repo to maven central.

from scala-xml.

som-snytt avatar som-snytt commented on June 3, 2024

Thanks for the mention, @adriaanm . I didn't have the gumption to adopt the module, but it's nice to see folks step up who can also exercise it!

from scala-xml.

ashawley avatar ashawley commented on June 3, 2024

@biswanaths Release notes look good!

All the items under "Administrative" are TBD -- they're not done yet. I only proposed those things. Sorry if that wasn't clear. Were you planning on doing them?

from scala-xml.

adriaanm avatar adriaanm commented on June 3, 2024

@som-snytt, I'd love to take credit, but I didn't write the release notes, was just pasting them. @biswanaths wrote them

from scala-xml.

som-snytt avatar som-snytt commented on June 3, 2024

Thanks @biswanaths ! What conscientiousness! Except for the part about not pasting the release notes. Just kidding!

from scala-xml.

lespea avatar lespea commented on June 3, 2024

Any update on getting this released?

from scala-xml.

biswanaths avatar biswanaths commented on June 3, 2024

I would like to address this #99 before pushing the release. Seems we are missing some paths for the OOM fix. Hopefully in couple of days.

from scala-xml.

lespea avatar lespea commented on June 3, 2024

Oh yeah that seems like a good plan. Thanks for the update!

from scala-xml.

ashawley avatar ashawley commented on June 3, 2024

Change mimaPreviousVersion in build.sbt to more recent scala-xml than 1.0.1

I tried making this change in #98, but it didn't ended up going very smoothly for reasons I don't understand. It's not a blocker for the next release, though.

from scala-xml.

ashawley avatar ashawley commented on June 3, 2024

Ok, I resolved the issue with Mima by adding a commit to #98 that fixed it. I'd say we are good to release a new version of scala-xml once #98 and #100 are merged!

from scala-xml.

 avatar commented on June 3, 2024

Any ETA when this release due out in the wild? Keen to see #59 & #99 get out there. Looks like most things are ready to go. TIA

from scala-xml.

EdgeCaseBerg avatar EdgeCaseBerg commented on June 3, 2024

Really looking forward to seeing #58 resolved! Is this going to be released soon?

from scala-xml.

SethTisue avatar SethTisue commented on June 3, 2024

@biswanaths do you need help? perhaps some of the people commenting on this ticket could help you.

from scala-xml.

biswanaths avatar biswanaths commented on June 3, 2024

@SethTisue , let me get through this.

from scala-xml.

ashawley avatar ashawley commented on June 3, 2024

Excellent! Thank you, @biswanaths! Looking forward to the release.

from scala-xml.

biswanaths avatar biswanaths commented on June 3, 2024

@adriaanm , @SethTisue Can any of you help with
" Ask Scala compiler to update versions.properties to next release of scala-xml" ?

from scala-xml.

SethTisue avatar SethTisue commented on June 3, 2024

Ask Scala compiler to update versions.properties to next release of scala-xml

tracking as scala/scala-dev#227. we'll get it in 2.12.1, assuming the 1.0.6 release goes well

from scala-xml.

biswanaths avatar biswanaths commented on June 3, 2024

@adriaanm , https://github.com/scala/scala-xml/releases/tag/v1.0.6

Do I need to do anything else ? As mentioned previously can you help us pushing this to maven central ?

from scala-xml.

ashawley avatar ashawley commented on June 3, 2024

@biswanaths Seems like #108 could be merged and added to 1.0.6. What do you think?

from scala-xml.

biswanaths avatar biswanaths commented on June 3, 2024

@ashawley Sure enough. Already did a merge. I think have to look into creating new tag and release.

from scala-xml.

SethTisue avatar SethTisue commented on June 3, 2024

over at https://oss.sonatype.org/content/repositories/orgscala-lang-1342/org/scala-lang/modules/ we see artifacts for 2.11, 2.12.0-M1, and 2.12.0-M5. since there are no 2.12.0-RC1 artifacts, since #108 was only merged later, instead of promoting that staging repository to Maven Central, I suggest we let it expire. you can delete the old v1.0.6 tag (keep a copy of the release notes!), merge #108, then push a new tag and Travis should publish again. once that's done, comment here and I'll take a look over on Sonatype to see if we got something we can promote this time.

from scala-xml.

SethTisue avatar SethTisue commented on June 3, 2024

@adriaanm , @SethTisue Can any of you help with
" Ask Scala compiler to update versions.properties to next release of scala-xml" ?

yes, scala/scala#5410

from scala-xml.

SethTisue avatar SethTisue commented on June 3, 2024

@biswanaths I took the liberty of revising the notes at https://github.com/scala/scala-xml/releases/tag/v1.0.6 a bit. in particular, I separated actual user-visible changes from other sorts of changes, and put the user-visible changes first. you might want to double-check that I classified the items correctly

from scala-xml.

biswanaths avatar biswanaths commented on June 3, 2024

@SethTisue , release notes look much better.

from scala-xml.

biswanaths avatar biswanaths commented on June 3, 2024

@SethTisue , deleting the tag and re-releasing with #108 as suggested by you looks better. We will do as such.

from scala-xml.

biswanaths avatar biswanaths commented on June 3, 2024

Done, deleted the tag and released. @SethTisue let me know if you need anything else to push to sonatype. Also do we need to push it to maven central ?

from scala-xml.

SethTisue avatar SethTisue commented on June 3, 2024

I closed and released the staging repos (there were two this time, I guess it must be timing-dependent whether you get one or two) at oss.sonatype.org just now (it's a manual step in the process that we do through the Sonatype web UI), so the artifacts should show up on Maven Central soon (within the next hour or so)

from scala-xml.

SethTisue avatar SethTisue commented on June 3, 2024

1.0.6 is on Maven Central

from scala-xml.

SethTisue avatar SethTisue commented on June 3, 2024

All the items under "Administrative" are TBD -- they're not done yet. I only proposed those things. Sorry if that wasn't clear. Were you planning on doing them?

@ashawley can you double-check the release notes?

from scala-xml.

ashawley avatar ashawley commented on June 3, 2024

The release notes look good to me. Those are indeed the user-visible changes that you listed first. Thanks!

from scala-xml.

SethTisue avatar SethTisue commented on June 3, 2024

Should we tweet about this from http://twitter.com/scala_lang ?

from scala-xml.

biswanaths avatar biswanaths commented on June 3, 2024

@SethTisue , would be great if we tweet. Hope it will drive towards some activity and help us.

from scala-xml.

SethTisue avatar SethTisue commented on June 3, 2024

https://twitter.com/scala_lang/status/779062887939575808

from scala-xml.

SethTisue avatar SethTisue commented on June 3, 2024

re: driving activity, scala_lang could retweet something you tweeted yourself, as well

from scala-xml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.