SciJava Commands fail silently

[kephale]

SciJava Commands fail silently

[kephale]

I think one of the issues here is an example of a silently failing command: #438

[moreApi]

In #477 Curtis mentioned scijava/scijava-common#452 as a cause for this issue

[kephale]

We could potentially catch these ourselves with this strategy: scijava/scijava-common#452 (comment)

[ctrueden]

@kephale I'm happy to fix this at the SJC framework level, which would finally close scijava/scijava-common#452 properly, but I'd like your opinion on what you think should happen when a module errors:

1. logService.error(exc)
2. uiService.showDialog(exc.getMessage(), DialogPrompt.MessageType.ERROR_MESSAGE)
3. Both
4. Something else

[kephale]

1 would pull up the console and show the error?
2 would be prettier, but maybe 1 is sufficient and possibly less intrusive...

My vote is for consistency with Fiji (which I think might be 1?)

[ctrueden]

After digging into this issue again today for a while, I confirmed that the problem is actually already fixed, with the behavior of (1). However, when running in IntelliJ IDEA, it seems to be snarfing up the stderr and putting it only into its own log window, such that it no longer appears in the SciJava Console window. At least that's my theory. I'll be doing more testing tomorrow in an actual Fiji app outside of IntelliJ, so I'll be able to confirm for sure then. I'll wait to close this until I'm sure all is well, though.

[ctrueden]

All right, confirmed, scijava/scijava-common#459 does fix this issue. I forced a sciview command to throw a RuntimeException, and then I see it now on both the actual console and the in SciJava graphical console window. 👍