Giter Site home page Giter Site logo

Comments (5)

ArtemSmaznov avatar ArtemSmaznov commented on July 18, 2024 1

I see, let me play around with it this evening and I'll get back to you by tomorrow

from wofi-pass.

schmidtandreas avatar schmidtandreas commented on July 18, 2024

The reason for that is, that you have to adjust the WOFI_PASS_AUTOTYPE variable. The default value is:
username :tab :password
In your case it should be login :tab :password.
Is this an acceptable solution for you?

Little bit more background:
wofi-pass currently supports only the following keywords for autotype:

  • :tab
  • :enter
  • :space
  • :password
  • :delay
  • :otp

All other keywords (not lead by :) are fields and have to match with the entry in pass, even username or in your case login.

Optional solution for that could be the definition of new keyword for autotype format, like:
:username and if this keyword is used by WOFI_PASS_AUTOTYPE the wofi-pass would output the content for the field defined in PASS_FIELD_USERNAME.

Is it still necessary to use the PASS_FIELD_USERNAME with the new implementation of WOFI_PASS_AUTOTYPE ? Because this approach solves your problem with more flexibility as you can now use any pass field for autotype, whether it is username or login or something else. Additionally you can even customize it for each entry of pass.

from wofi-pass.

ArtemSmaznov avatar ArtemSmaznov commented on July 18, 2024

didn't have the time yet to fully check the code but I see this in there now
WOFI_PASS_AUTOTYPE="${WOFI_PASS_AUTOTYPE:-"${PASS_FIELD_USERNAME} :tab :password"}"
so it looks like the default autotype should respect PASS_FIELD_USERNAME but it doesn't for some reason.
I'll try setting it manually in the config after work today but it still feels like a bug tbh.

from wofi-pass.

schmidtandreas avatar schmidtandreas commented on July 18, 2024

Yes, you are right. But this works only for command line calls: PASS_FIELD_USERNAME=login wofi-pass -at
Not for changes in configuration file.

I agree with you that is not intuitive handling of PASS_FIELD_USERNAME. But the implementation of more intuitive handling could be IMO "ugly", because I have to recognize if WOF_PASS_AUTOTYPE was set in config file or not and if not set but PASS_FIELD_USERNAME is changed then the WOFI_PASS_AUTOTYPE should be reinitialized. This make the reading of config file more complicated and depending of pass fields. I would prefer to delete the PASS_FIELD_USERNAME handling, because you can define any field for autotype now, independent if it username or something else. What do you thing?

from wofi-pass.

schmidtandreas avatar schmidtandreas commented on July 18, 2024

Hi, I have been thinking a bit and I think the best way to solve this issue is to define the new keyword for autotype :username and use this keyword in the default in WOFI_PASS_AUTOTYPE. So the username defined by PASS_FIELD_USERNAME can be used, on the other hand everyone can still use pass fields directly. I have created a PR #9. See if it works for you.

from wofi-pass.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.