Support 'ngInject' string-based annotation

[schmod]

Support 'ngInject' string-based annotation

[schmod]

Do you have a reason for preferring this style?

I generally haven't seen it used much in the wild, and @-prefixed comments seem to be the standard convention for annotating JS sources, and mimic the annotation syntax used in ES6/Java/Python.

[mgol]

I guess you're right in that it reminds other tools more.

My preference came from a few things:

1. The fact that I have 'ngInject'; sprinkled all over my projects so migrating to this Babel plugin would require refactoring. 😄
2. It resembles "use strict", "use asm" etc. a little.
3. ng-annotate itself has described this way as the preferred one: https://github.com/olov/ng-annotate#explicit-annotations-with-nginject

[mgol]

See also olov#180 (comment) and olov#206. I have an impression that quite many people think the 'ngInject'; pragma is the recommended way, some even think other forms are deprecated. :) In some cases it's the only way as some transpilers will lose comments or misplace them.

Adding this way of annotating would increase the compatibility with the original ng-annotate.

[mgol]

Thanks! 🎉

[schmod]

Huh. I didn't realize that it had emerged as the preference.

Fortunately, it's also a whole lot easier to implement.

Unless I'm missing something, I think class constructors are the only new ES6 feature where a prologue would be useful/usable. Can you think of any place else where this would be useful?

Class methods come to mind, but is there an actual use-case for that?

[mgol]

I'd expect it to be used only for class constructors, at least I don't see use cases for annotating methods. If some come up, it can always be added later, I guess. :)