Comments (4)
Seems reasonable, and shouldn't be terribly difficult to implement. I'll see what I can do.
from babel-plugin-angularjs-annotate.
Is there any benefit of being able to individually enable/disable the /* @ngInject */
and 'ngInject'
matchers (ie. disable comment-based annotations, but keep prologue-based annotations), or will it be sufficient to add a toggle that disables implicit matches?
from babel-plugin-angularjs-annotate.
I think disabling all implicit matches should be enough (at least it would for me); disabling one explicit annotation style is more a job for a linter if someone wants sth like that.
from babel-plugin-angularjs-annotate.
While looking at the existing test cases, I stumbled across this:
/* @ngInject */
function MyDirective2($stateProvider) {
$stateProvider.state('astate', {
resolve: {
yoyo: function(ma) {
},
}
});
}
When we're doing "explicit-only" annotating, I think it's reasonable to assume that the above code sample would not work correctly, unless an additional /* @ngInject */
or 'ngInject'
was added to yoyo
.
When we add an ngInject
annotation to a node, I don't think that our users should assume that implicit matching will be enabled for anything inside that node. (Implementing this would be difficult, and IMO, the results could be unpredictable).
I don't really have a question about this... just wanted to write it down somewhere so that it can come back to haunt me later on.
from babel-plugin-angularjs-annotate.
Related Issues (20)
- Support for @ngInject within JSDoc blocks HOT 2
- 0.8.2 is extremely slow HOT 5
- $inject is not added on exported class when transforming to ES5 HOT 1
- Remove prologue string? HOT 1
- Any way to catch babel-renamed function arguments? HOT 3
- "Module 'xxx' is not available!" errors when converting from ngAnnotate HOT 2
- babel 7 support HOT 8
- Not working when some property of the class has a Decorator HOT 2
- Unexpected token HOT 2
- Question not issue babel-plugin-angularjs-annotate for replace ng-annotate with grunt HOT 3
- Method names can shadow import names HOT 1
- Option for a decorator HOT 1
- doesn't work with babel-core >= 7.0 HOT 1
- Project with angular and vue code
- codeFrame is not a function
- Cannot set property $inject of function SomeController which has only a getter HOT 6
- Can not inject dependencies on class when declared on an object property
- Underscore "_" breaks annotations when "@babel/plugin-proposal-class-properties" is used
- What does "Declarator name different _elementReadyDirectiveFactory" actually indicate?
- Unit tests failing since `@babel/plugin-transform-classes` 7.16.5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from babel-plugin-angularjs-annotate.