data race

data race

one more case

croc

                                ,_
                               >' )
   croc version                ( ( \
                                || \
                 /^^^^\         ||
    /^^\________/0     \        ||
   (                    `~+++,,_||__,,++~^^^^^^^
 ...V^V^V^V^V^V^\...............................


Enter receive code: 4-happy-diego-tribune
The specifed code is already in use by a sender.
==================
WARNING: DATA RACE
Write at 0x00c42008428a by goroutine 11:
  main.(*Connection).runClient.func1()
      /Users/callmeanyhow/go/src/croc/connect.go:298 +0xd86

Previous write at 0x00c42008428a by goroutine 7:
  main.(*Connection).runClient.func1()
      /Users/callmeanyhow/go/src/croc/connect.go:298 +0xd86

Goroutine 11 (running) created at:
  main.(*Connection).runClient()
      /Users/callmeanyhow/go/src/croc/connect.go:231 +0x510
  main.(*Connection).Run()
      /Users/callmeanyhow/go/src/croc/connect.go:206 +0x80b
  main.main()
      /Users/callmeanyhow/go/src/croc/main.go:66 +0x573

Goroutine 7 (finished) created at:
  main.(*Connection).runClient()
      /Users/callmeanyhow/go/src/croc/connect.go:231 +0x510
  main.(*Connection).Run()
      /Users/callmeanyhow/go/src/croc/connect.go:206 +0x80b
  main.main()
      /Users/callmeanyhow/go/src/croc/main.go:66 +0x573
==================
Found 1 data race(s)

[schollz]

Whoa! How did you get these errors, just by go get and then running? I've never seen errors like these before.

Almost) I used standard golang race detector go install -race .

[schollz]

Okay, thanks. The problem is how data is being shared. Namely these contain switches: https://github.com/schollz/croc/blob/master/connect.go#L224-L228. These switches can be turned off/on simultaneously by threads which causes data racing. It should be fixed now since I added a sync.RWMutex to hold these switches.