sciactive/nephele

A pluggable WebDAV, CardDAV, and CalDAV server for Node.js and Express.

nephele's Issues

(@nephele/adapter-file-system) Partially uploaded file is not writable by user.

If a file fails to upload, and ends up in a partially uploaded state, then the adapter never chowns it to the user, meaning it is not writable by the user.

urlToRelativePath() in Adapters seems wrong if express mountpoint is not `/`

Hi, first off, thanks for the great module!

The code works fine when mounted on /.

I was trying to mount nephele in a subpath on express:

app.use('/webdav', nephele({
            adapter: new FileSystemAdapter({
                root: '/data/root/',
            }),
            authenticator: new InsecureAuthenticator(),
        })
}; 

This in turn will, as expected, hit https://github.com/sciactive/nephele/blob/master/packages/adapter-file-system/src/Adapter.ts#L87 in various places.

The issue is, that the url in express.js would already have the mountpoint (ie baseurl) removed from the path when hitting nephele. So the check for path having baseUrl fails. Skipping that prefix check and also removing the subsequent .substring(decodeURIComponent(baseUrl.pathname).length) will fix the issue.

Further code handles listing and at least retrieving files and contents fine, but after some debugging, I couldn't quite find how the absolute paths (which are wrong, as they contain the mountpoint) are constructed. Writing files does not work as the absolute path ends up being wrong.

Maybe I am hitting some unsupported path here, but should nephele work with the filesystem adapter on an express mountpoint in the first place?

Happy to do further debugging if this is not easily reproducible or I have some more pointers in the right direction.

Outlook does not seems to be able to connect to `nephele` server

I am able to connect with nephele using a simple test client with webdav package.
However, trying to publish an Outlook calendar with Outlook's Publish to WebDAV feature, the connect could not be established.

Locks must not be copied and/or moved with resources.

Currently, locks are copied and moved with resources. This goes against the spec.

Is it possible to achieve a link based FS?

I'm currently using webdav-server but I'm facing problems when passing a direct dl link connected to a file. If the file is too big, the stream is loaded into memory and it breaks. I assume the issue lies in the fact that its trying to load a huge amount of data into memory. My biggest problem is media files such as MP4 etc.

Just wondering if there's a way to only load parts of what the user requested, if its a media file for example?

And is this doable in nephele?

Docker and `AUTH=false` doesn't work

I tried all variances of using AUTH=false, by docker-compose.yaml, inline docker run command, S3 storage, normal storage,... but it does not seems to work.
Setting AUTH_USERNAME or using .htpasswd does work normally.