Comments (2)
Hi everyone,
I just checked the code of fit
in MDLPVectDiscretizer
and I agree with the proposed fix. By reading the code, one can see that the search routine in the fit
method does not guarantee sorted cut points because these are stored in a standard set, which does not guarantee sorted values (besides the routine itself does not guarantee that the cut points are added to the set in increasing or decreasing order, so a list is not a choice either). Another solution could be to use a sorted set in line 116 of mdlp_discretizer.py. That makes the code dependent on sortedcontainers, which on the other hand, is declared as a dependency.
from scikit-mine.
cut_points_ is now sorted with the following fix: self.cut_points_ = np.array(sorted(list(cut_points))
. The second issue (#134 ) on MDLPDiscretizer will be considered soon.
from scikit-mine.
Related Issues (20)
- avoid data copies in PeriodicCycleMiner
- SLIM for high dimensional data HOT 1
- Make scikit-mine profile friendly HOT 2
- KRIMP Imputation
- MDLP Discretizer v2 HOT 1
- notebook for PeriodicCycleMiner
- fetch_instancart is broken HOT 1
- [perf] skmine.periodic.cycles.extract_triples is really slow for n_points > 200
- Question about parameter k of SLIM HOT 2
- Return type of SLIM HOT 4
- Don't understand return values of decision_function of SLIM HOT 3
- apriori and CBA HOT 1
- inherit sklearn BaseEstimator HOT 2
- MDLPDiscretizer: cut_points_ sometimes contains ambiguous values HOT 1
- max_time follows an anti-pattern in SLIM HOT 1
- preprocessing of transactionnal database affect code length HOT 2
- OneVsOneClassifier for SLIM doesnt't work
- environment for doc generation
- CoverTransformer HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scikit-mine.