BLD/DEV: special: build warnings

[fancidev]

BLD/DEV: special: build warnings

[lucascolley]

The highs one is known, see gh-19734. I believe @steppi is intending to circle back to any new warnings from special at some point.

[steppi]

The following warning seems to reveal that a } is missing due to misleading indentation:

I see, it does look like there's a missing bracket in the final if block of hy1f1a. I think this was just copied verbatim from the original cephes code, which probably had this same issue. Actually it looks like I introduced this one. In any case I'll submit a PR with a fix.

[fancidev]

@lucascolley Sorry about early closure. Feel free to update the task list in the original post to leverage on GitHub’s task tracking GUI.

[lucascolley]

I also see

[47/1383] Generating symbol file scipy/special/libsf_error_state.dylib.p/libsf_error_state.dylib.symbols
WARNING: ['arm64-apple-darwin20.0.0-nm'] does not work. Relinking will always happen on source changes.
error: arm64-apple-darwin20.0.0-nm: invalid argument --
Usage: arm64-apple-darwin20.0.0-nm [-agnopruUmxjlfAPL[s segname sectname] [-] [-t format] [[-arch <arch_flag>] ...] [file ...]
...
[70/1383] Compiling C++ object scipy/special/_gufuncs.cpython-310-darwin.so.p/_gufuncs.cpp.o
...
In file included from ../scipy/special/_gufuncs.cpp:1:
../scipy/special/_gufuncs.cpp:57:5: warning: mixture of designated and non-designated initializers in the same initializer list is a C99 extension [-Wc99-designator]
    .m_name = "_gufuncs",
    ^~~~~~~~~~~~~~~~~~~~
../scipy/special/_gufuncs.cpp:56:5: note: first non-designated initializer is here
    PyModuleDef_HEAD_INIT,
    ^~~~~~~~~~~~~~~~~~~~~
/Users/lucascolley/mambaforge/envs/scipy-dev/include/python3.10/moduleobject.h:51:31: note: expanded from macro 'PyModuleDef_HEAD_INIT'
#define PyModuleDef_HEAD_INIT { \
                              ^~~

[fancidev]

@steppi I can make a PR for the first warning if you want. It’s an easy fix, though the code will not look pretty as import_array and import_umath are macros with a return statement in it.

[steppi]

@steppi I can make a PR for the first warning if you want. It’s an easy fix, though the code will not look pretty as import_array and import_umath are macros with a return statement in it.

Thanks @fancidev, that would be great.

[fancidev]

Actually it is already fixed by @rgommers !

[lucascolley]

this is not actually done quite yet, remaining warnings for me locally:

• 1:

[48/1383] Generating symbol file scipy/special/libsf_error_state.dylib.p/libsf_error_state.dylib.symbols
WARNING: ['arm64-apple-darwin20.0.0-nm'] does not work. Relinking will always happen on source changes.
error: arm64-apple-darwin20.0.0-nm: invalid argument --
Usage: arm64-apple-darwin20.0.0-nm [-agnopruUmxjlfAPL[s segname sectname] [-] [-t format] [[-arch <arch_flag>] ...] [file ...]

• 2:

[71/1383] Compiling C++ object scipy/special/_gufuncs.cpython-310-darwin.so.p/_gufuncs.cpp.o
../scipy/special/_gufuncs.cpp:57:5: warning: mixture of designated and non-designated initializers in the same initializer list is a C99 extension [-Wc99-designator]
    .m_name = "_gufuncs",
    ^~~~~~~~~~~~~~~~~~~~
../scipy/special/_gufuncs.cpp:56:5: note: first non-designated initializer is here
    PyModuleDef_HEAD_INIT,
    ^~~~~~~~~~~~~~~~~~~~~
/Users/lucascolley/mambaforge/envs/scipy-dev/include/python3.10/moduleobject.h:51:31: note: expanded from macro 'PyModuleDef_HEAD_INIT'
#define PyModuleDef_HEAD_INIT { \
                              ^~~
1 warning generated.

• 3:

[90/1383] Compiling C++ object scipy/special/_special_ufuncs.cpython-310-darwin.so.p/_special_ufuncs.cpp.o
../scipy/special/_special_ufuncs.cpp:210:5: warning: mixture of designated and non-designated initializers in the same initializer list is a C99 extension [-Wc99-designator]
    .m_name = "_special_ufuncs",
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../scipy/special/_special_ufuncs.cpp:209:5: note: first non-designated initializer is here
    PyModuleDef_HEAD_INIT,
    ^~~~~~~~~~~~~~~~~~~~~
/Users/lucascolley/mambaforge/envs/scipy-dev/include/python3.10/moduleobject.h:51:31: note: expanded from macro 'PyModuleDef_HEAD_INIT'
#define PyModuleDef_HEAD_INIT { \
                              ^~~
1 warning generated.