Comments (2)
@rentzso: Please take this on. I'd suggest that we generally prefer orphaned files over stale database entries. That is, for uploads, place file first, then update database, and for deletes, update database first, then delete file. Actually, with our new hash-based file storage, deletion will need to be handled by a cleanup job. For that, we just need an endpoint; cron functionality will be handled external to the api.
from core.
I have created this pull request to fix this:
#118
The code was handling and cleaning only after IOErrors, but not OSErrors.
Deletes are already done only on the DB, and not on the file system and, as @gsfr was saying, we need the endpoint to do the cleanup.
from core.
Related Issues (20)
- Integration tests fail with Mongo 3.6
- Files without expected keys (tags, measurements, etc) fail job enqueueing process
- Subject in session list includes sanitized fields
- Provide an alias for the '+' and '-' attributes in download filters
- Remove `root` Flag HOT 3
- Content-Length missing on /jobs/x/config.json HOT 2
- Formalize "adhoc" analyses
- Remove non-ticketed job completion
- GETting info for a file fails when the file has no info key
- Allow site admins to change user IDs HOT 1
- Allow Filenames with slashes HOT 4
- Remove ability to view "all_data" without site admin privs in search
- Generate index for Swagger branch and tag documentation
- Change default link in swagger API documentation
- Replacement of a file should trigger gear rule HOT 17
- Analysis jobs do not transition to complete state when using completion tickets HOT 3
- Add missing swagger docs for reports endpoints
- Add missing swagger docs for jobs prepare-complete endpoint
- Add missing swagger docs for resolver endpoint
- Metadata for gears run on session files does not get saved
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core.