Simplifying color argument

[sckott]

Simplifying color argument

[sckott]

Thanks for your issue @ecrs98 ! I'm so glad it makes coding more fun.

What do you think @aedobbyn ? Does this seem like a good idea, and if so, can it be done easily?

[sckott]

@ecrs98 let's wait a bit to see if amanda responds. if not soon, we can move ahead discussing this

[aedobbyn]

hi, so glad you like the package! so my first instinct here is that it would be possible to do of course, but that this argument would be redundant given that it's covered by the other two already there so i don't love it design-wise. what do you think @sckott?

[sckott]

Thanks @aedobbyn ! One idea is we could do in the function definition

say <- function(what="Hello world!", by="cat",
                type=NULL,
                what_color=NULL, by_color=what_color, <--------- 
                length=18, fortune=NULL, ...) 

Where we set by_color to be whatever is set in what_color UNLESS by_color is set to something by the user. NULL is still the default for by_color here.

I agree I don't think we should add a new parameter.