Giter Site home page Giter Site logo

Comments (6)

akinomyoga avatar akinomyoga commented on July 23, 2024

Ah, this change is the problem:

b603535#diff-a4757074ff650000804fd3eaabe9b0a9e02e33040ca5b8afd4c0275fc5f3e136R1694

I don't remember why I did this change. I possibly tried to handle it in the awk script and removed %[[:punct:]], but I later gave up handling it in the awk script forgetting to restore %[[:punct:]].

from bash-completion.

yedayak avatar yedayak commented on July 23, 2024

Note that this also breaks interfaces that look like this veth0@veth1, _comp_compgen_available_interfaces returns the entire thing when it should only return veth0

from bash-completion.

akinomyoga avatar akinomyoga commented on July 23, 2024

Thank you for the information. I'd like to confirm. Do you mean "veth0@ or veth1@"? Or is it actually veth0@veth1? I don't think the latter was broken by the change because veth0@veth1 cannot be modified to veth0 by "${generated[@]/%[[:punct:]]/}", i.e. it was broken from the beginning if you mean veth0@veth1.

from bash-completion.

yedayak avatar yedayak commented on July 23, 2024

Thank you for the information. I'd like to confirm. Do you mean "veth0@ or veth1@"? Or is it actually veth0@veth1? I don't think the latter was broken by the change because veth0@veth1 cannot be modified to veth0 by "${generated[@]/%[[:punct:]]/}", i.e. it was broken from the beginning if you mean veth0@veth1.

I mean the latter veth0@veth1, I guess it was broken even before this change

from bash-completion.

akinomyoga avatar akinomyoga commented on July 23, 2024

Thanks! So, something like "${generated[@]%%[[:punct:]]*}" might be better.

from bash-completion.

scop avatar scop commented on July 23, 2024

Oops, I somehow failed to follow the discussion here. It's likely things were broken also before this changes, but let's continue the discussion about the correct behavior in #1133.

from bash-completion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.