Comments (6)
Hi @wRAR ,
I'm new to open-source and would love to work on this.
Can you point me to what needs to be done?
from scrapy.
There is a test here that it seems will start failing in newer versions of Python 3.11+. Specifically this line, from what @wRAR described on the linked issue.
@wRAR suggests changing the test expectations to be something like self.assertIn(…, [[], ["obj"]])
(assuming ["obj"]
is the new expectation), i.e. assert that the result is either []
or ["obj"]
.
from scrapy.
Does this include removing the conditional check (checking for CPython/PyPy) too? If yes, do we remove it entirely, or check only for PyPy?
from scrapy.
Assuming my guess is correct and the new expectation is ["obj"]
as in PyPy, then removing the platform checks altogether makes sense.
from scrapy.
One thing though: I would keep the URL of the Python issue, for future reference. Maybe just the URL, though, now that it has been fixed in newer versions.
from scrapy.
I'll push in a change. Thanks!
from scrapy.
Related Issues (20)
- SCRAPER_SLOT_MAX_ACTIVE_SIZE - documentations HOT 1
- CachingHostnameResolver with CONCURRENT_REQUESTS_PER_IP fails HOT 7
- Document stats produced by Scrapy
- AttributeError: 'SelectReactor' object has no attribute '_handleSignals' HOT 2
- Fails to fetch request with hyphens in 3rd and 4th position of domain
- is there any method can add decorator on parse function? HOT 5
- Remove top-level reactor imports from CrawlerProces/CrawlerRunner examples HOT 5
- Possible improvement: this check depends on scrapy response properly converted to XmlResponse instance HOT 3
- Undeprecate and add back to defaults the off-domain spider middleware HOT 2
- Fix overridable methods in MediaPipeline HOT 1
- Latest allowed_domains behavior breaks middlewares that rewrite urls HOT 4
- persist_file() can return a Deferred that is never awaited
- Enhance Tutorial Documentation for Improved Clarity and Usefulness
- Edit Contributing.rst document to specify how to propose documentation suggestions HOT 11
- Error handling in contract parsing HOT 2
- Response.json() method not fully documented HOT 2
- Custom Log Formatter doesn't override download_error method. HOT 18
- Improve the docs of the dont_filter parameter of Request
- .. _topics-contributing: HOT 1
- Documentation - specify how to propose non programming and programming changes HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scrapy.