Giter Site home page Giter Site logo

Comments (6)

 avatar commented on June 14, 2024

Hi @wRAR ,

I'm new to open-source and would love to work on this.
Can you point me to what needs to be done?

from scrapy.

Gallaecio avatar Gallaecio commented on June 14, 2024

There is a test here that it seems will start failing in newer versions of Python 3.11+. Specifically this line, from what @wRAR described on the linked issue.

@wRAR suggests changing the test expectations to be something like self.assertIn(…, [[], ["obj"]]) (assuming ["obj"] is the new expectation), i.e. assert that the result is either [] or ["obj"].

from scrapy.

 avatar commented on June 14, 2024

Does this include removing the conditional check (checking for CPython/PyPy) too? If yes, do we remove it entirely, or check only for PyPy?

from scrapy.

Gallaecio avatar Gallaecio commented on June 14, 2024

Assuming my guess is correct and the new expectation is ["obj"] as in PyPy, then removing the platform checks altogether makes sense.

from scrapy.

Gallaecio avatar Gallaecio commented on June 14, 2024

One thing though: I would keep the URL of the Python issue, for future reference. Maybe just the URL, though, now that it has been fixed in newer versions.

from scrapy.

 avatar commented on June 14, 2024

I'll push in a change. Thanks!

from scrapy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.