Giter Site home page Giter Site logo

Comments (2)

danmichaelo avatar danmichaelo commented on August 23, 2024

Agree that the solution is not a good one. A better solution could be to only add $c if it follows $a. Then the test should still pass without any break/continue stuff.

But if the example in testComplexTableEntryWithUndocumentStuff is really invalid MARC21 Classification, it would also be better to have it fixed and remove the test. I will start asking the NO editorial team what they think about the example.

from mc2skos.

danmichaelo avatar danmichaelo commented on August 23, 2024

The example used in the test has since been fixed, so I think it's safe to remove this. And if I find new cases, I can try a better fix like adding $c only if it follows `$a

from mc2skos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.